You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/02 00:35:44 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #9947: [GH-9708] Add type annotation to providers/jenkins

mik-laj commented on a change in pull request #9947:
URL: https://github.com/apache/airflow/pull/9947#discussion_r464014698



##########
File path: airflow/providers/jenkins/operators/jenkins_job_trigger.py
##########
@@ -94,11 +99,12 @@ class JenkinsJobTriggerOperator(BaseOperator):
 
     @apply_defaults
     def __init__(self,
-                 jenkins_connection_id,
-                 job_name,
-                 parameters="",
-                 sleep_time=10,
-                 max_try_before_job_appears=10,
+                 jenkins_connection_id: str,
+                 job_name: str,
+                 parameters: str = "",

Review comment:
       ```suggestion
                    parameters: Optional[Union[str, Dict]] = None,
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org