You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Garrett Rooney <ro...@electricjellyfish.net> on 2006/01/16 01:32:09 UTC

[PATCH] fix warning in mod_usertrack.c

While playing around with httpd on win32 today, I noticed a small
warning in mod_usertrack.c.

>
>    cls->expires = modifier;
>

The problem here is that modifier is a time_t, and cls->expires is an
int, and Visual C++ Express 2005 is unthrilled about the possibility
for data loss there.

I threw together a patch that changes expires to a time_t, and then
adjusted the only place in the file that really cares about that (an
apr_psprintf that uses expires, and thus needs to be cast up to an
unsigned 64 bit int and printf'd via APR_UINT64_T_FMT, since there's
no portable printf format string for time_t), but I don't actually
have any way to test it, so I figured I'd throw it at this list and
see if people thought it looked reasonable.  It does fix the warning,
no promises about what it does at runtime though...

-garrett

Fix warning in mod_usertrack.c

* modules/metadata/mod_usertrack.c
  (cookie_log_state): Make expires a time_t instead of an int.
  (make_cookie): Adjust apr_psprintf call to take into acount new type
   for expires.