You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/14 02:35:04 UTC
[GitHub] [airflow] yingxuanwangxuan opened a new pull request, #25042: Fix grid data auto refresh
yingxuanwangxuan opened a new pull request, #25042:
URL: https://github.com/apache/airflow/pull/25042
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] cloventt commented on a diff in pull request #25042: No grid auto-refresh for backfill dag runs
Posted by GitBox <gi...@apache.org>.
cloventt commented on code in PR #25042:
URL: https://github.com/apache/airflow/pull/25042#discussion_r954464632
##########
airflow/www/static/js/api/useGridData.ts:
##########
@@ -49,7 +49,7 @@ const emptyGridData: GridData = {
},
};
-export const areActiveRuns = (runs: DagRun[] = []) => runs.filter((run) => ['queued', 'running', 'scheduled'].includes(run.state)).length > 0;
+export const areActiveRuns = (runs: DagRun[] = []) => runs.filter((run) => ['manual', 'manual'].includes(run.runType)).filter((run) => ['queued', 'running', 'scheduled'].includes(run.state)).length > 0;
Review Comment:
Surely this should be:
```python
export const areActiveRuns = (runs: DagRun[] = []) => runs.filter((run) => ['scheduled', 'manual'].includes(run.runType)).filter((run) => ['queued', 'running', 'scheduled'].includes(run.state)).length > 0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #25042: No grid auto-refresh for backfill dag runs
Posted by GitBox <gi...@apache.org>.
bbovenzi merged PR #25042:
URL: https://github.com/apache/airflow/pull/25042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] yingxuanwangxuan commented on a diff in pull request #25042: No grid auto-refresh for backfill dag runs
Posted by GitBox <gi...@apache.org>.
yingxuanwangxuan commented on code in PR #25042:
URL: https://github.com/apache/airflow/pull/25042#discussion_r954646261
##########
airflow/www/static/js/api/useGridData.ts:
##########
@@ -49,7 +49,7 @@ const emptyGridData: GridData = {
},
};
-export const areActiveRuns = (runs: DagRun[] = []) => runs.filter((run) => ['queued', 'running', 'scheduled'].includes(run.state)).length > 0;
+export const areActiveRuns = (runs: DagRun[] = []) => runs.filter((run) => ['manual', 'manual'].includes(run.runType)).filter((run) => ['queued', 'running', 'scheduled'].includes(run.state)).length > 0;
Review Comment:
thanks for fix this. @bbovenzi can you review it again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] yingxuanwangxuan commented on pull request #25042: Fix grid data auto refresh
Posted by GitBox <gi...@apache.org>.
yingxuanwangxuan commented on PR #25042:
URL: https://github.com/apache/airflow/pull/25042#issuecomment-1184441766
what is this error，can you help me, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] josh-fell commented on pull request #25042: Fix grid data auto refresh
Posted by GitBox <gi...@apache.org>.
josh-fell commented on PR #25042:
URL: https://github.com/apache/airflow/pull/25042#issuecomment-1184566390
HI @yingxuanwangxuan, can you an explanation in the PR description of what's being fixed and how this PR resolves the issue. It's not entirely clear without a description or a linked issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #25042: No grid auto-refresh for backfill dag runs
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #25042:
URL: https://github.com/apache/airflow/pull/25042#issuecomment-1190106624
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #25042: Fix grid data auto refresh
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on PR #25042:
URL: https://github.com/apache/airflow/pull/25042#issuecomment-1184599513
Issue: https://github.com/apache/airflow/issues/24844
Not sure about the CI failure. I'd say rebase the branch and see if it persists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org