You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/19 04:48:07 UTC
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request
#4360: decouple find InsertValuesSegment with insert statement
terrymanu opened a new pull request #4360: decouple find InsertValuesSegment with insert statement
URL: https://github.com/apache/incubator-shardingsphere/pull/4360
For #4342.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4360:
decouple find InsertValuesSegment with insert statement
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4360: decouple find InsertValuesSegment with insert statement
URL: https://github.com/apache/incubator-shardingsphere/pull/4360
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4360:
decouple find InsertValuesSegment with insert statement
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4360: decouple find InsertValuesSegment with insert statement
URL: https://github.com/apache/incubator-shardingsphere/pull/4360#issuecomment-588039225
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4360?src=pr&el=h1) Report
> Merging [#4360](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4360?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/00f0db675f0f0ec0e622304b99a6d889446fd6c3?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4360?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4360 +/- ##
=========================================
Coverage 53.88% 53.88%
Complexity 351 351
=========================================
Files 1047 1047
Lines 19288 19288
Branches 3550 3550
=========================================
Hits 10393 10393
Misses 8238 8238
Partials 657 657
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4360?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...nerator/impl/ShadowInsertValuesTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4360/diff?src=pr&el=tree#diff-c2hhZG93LWNvcmUvc2hhZG93LWNvcmUtcmV3cml0ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvU2hhZG93SW5zZXJ0VmFsdWVzVG9rZW5HZW5lcmF0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...rator/impl/ShardingInsertValuesTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4360/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvU2hhcmRpbmdJbnNlcnRWYWx1ZXNUb2tlbkdlbmVyYXRvci5qYXZh) | `86.95% <100%> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...keygen/GeneratedKeyInsertValuesTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4360/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwva2V5Z2VuL0dlbmVyYXRlZEtleUluc2VydFZhbHVlc1Rva2VuR2VuZXJhdG9yLmphdmE=) | `90% <100%> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...erator/impl/EncryptInsertValuesTokenGenerator.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4360/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1yZXdyaXRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvRW5jcnlwdEluc2VydFZhbHVlc1Rva2VuR2VuZXJhdG9yLmphdmE=) | `75.34% <100%> (ø)` | `1 <0> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4360?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4360?src=pr&el=footer). Last update [00f0db6...00e1a56](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4360?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4360:
decouple find InsertValuesSegment with insert statement
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4360: decouple find InsertValuesSegment with insert statement
URL: https://github.com/apache/incubator-shardingsphere/pull/4360#issuecomment-588040591
## Pull Request Test Coverage Report for [Build 9641](https://coveralls.io/builds/28816892)
* **5** of **6** **(83.33%)** changed or added relevant lines in **4** files are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.005%**) to **57.341%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shadow-core/shadow-core-rewrite/src/main/java/org/apache/shardingsphere/shadow/rewrite/token/generator/impl/ShadowInsertValuesTokenGenerator.java](https://coveralls.io/builds/28816892/source?filename=shadow-core%2Fshadow-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshadow%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FShadowInsertValuesTokenGenerator.java#L52) | 0 | 1 | 0.0%
<!-- | **Total:** | **5** | **6** | **83.33%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28816892/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/28816892) |
| :-- | --: |
| Change from base [Build 878](https://coveralls.io/builds/28801195): | -0.005% |
| Covered Lines: | 11060 |
| Relevant Lines: | 19288 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4360: decouple find InsertValuesSegment with insert statement
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4360: decouple find InsertValuesSegment with insert statement
URL: https://github.com/apache/incubator-shardingsphere/pull/4360#issuecomment-588040591
## Pull Request Test Coverage Report for [Build 1805](https://coveralls.io/builds/28816921)
* **5** of **6** **(83.33%)** changed or added relevant lines in **4** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **57.347%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shadow-core/shadow-core-rewrite/src/main/java/org/apache/shardingsphere/shadow/rewrite/token/generator/impl/ShadowInsertValuesTokenGenerator.java](https://coveralls.io/builds/28816921/source?filename=shadow-core%2Fshadow-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshadow%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FShadowInsertValuesTokenGenerator.java#L52) | 0 | 1 | 0.0%
<!-- | **Total:** | **5** | **6** | **83.33%** | -->
| Totals | [](https://coveralls.io/builds/28816921) |
| :-- | --: |
| Change from base [Build 878](https://coveralls.io/builds/28801195): | 0.0% |
| Covered Lines: | 11061 |
| Relevant Lines: | 19288 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services