You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "C. Michael Pilato" <cm...@collab.net> on 2006/06/05 14:27:23 UTC
Re: python bindings test cases
Madan U Sreenivasan wrote:
> - There are some existing test cases in
> subversion/bindings/swig/python/tests/. But, these are not comprehensive
> (IMHO), and more importantly use imports from trac modules. Is there some
> specific purpose for making the tests dependant on trac?
We are using Trac's python bindings test suite.
> - The tests only test on file:// based urls. I think we should have tests
> like our existing cmdline tests, that can be run selectively on file://,
> http:// and svn://
Our python bindings are a test of the bindings themselves, not of the C code
behind the bindings. I think it is sufficient to only perform file://
testing in the bindings tests because that will exercise the Python-to-C
translation code in exactly the same way testing over the other RA layers would.
> - Given the above two points, I think we should be rewriting the tests.
And given my two responses, I think you're quite wrong. :-)
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Re: python bindings test cases
Posted by Madan U Sreenivasan <ma...@collab.net>.
On Mon, 05 Jun 2006 20:01:28 +0530, Garrett Rooney
<ro...@electricjellyfish.net> wrote:
> On 6/5/06, C. Michael Pilato <cm...@collab.net> wrote:
>> Madan U Sreenivasan wrote:
>> > - There are some existing test cases in
>> > subversion/bindings/swig/python/tests/. But, these are not
>> comprehensive
>> > (IMHO), and more importantly use imports from trac modules. Is there
>> some
>> > specific purpose for making the tests dependant on trac?
>>
>> We are using Trac's python bindings test suite.
>
> Last summer we imported part of the trac test suite, because it was
> the only available test suite for the python code, and they were
> willing to give it to us. It's not actually dependent on trac, it's
> stand alone, just depending on the code we have in the tree.
>
I see..
>> > - The tests only test on file:// based urls. I think we should have
>> tests
>> > like our existing cmdline tests, that can be run selectively on
>> file://,
>> > http:// and svn://
>>
>> Our python bindings are a test of the bindings themselves, not of the C
>> code
>> behind the bindings. I think it is sufficient to only perform file://
>> testing in the bindings tests because that will exercise the Python-to-C
>> translation code in exactly the same way testing over the other RA
>> layers would.
>
> +1
okay.
Thank you guys for clarifying :)
Regards,
Madan.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: python bindings test cases
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 6/5/06, C. Michael Pilato <cm...@collab.net> wrote:
> Madan U Sreenivasan wrote:
> > - There are some existing test cases in
> > subversion/bindings/swig/python/tests/. But, these are not comprehensive
> > (IMHO), and more importantly use imports from trac modules. Is there some
> > specific purpose for making the tests dependant on trac?
>
> We are using Trac's python bindings test suite.
Last summer we imported part of the trac test suite, because it was
the only available test suite for the python code, and they were
willing to give it to us. It's not actually dependent on trac, it's
stand alone, just depending on the code we have in the tree.
> > - The tests only test on file:// based urls. I think we should have tests
> > like our existing cmdline tests, that can be run selectively on file://,
> > http:// and svn://
>
> Our python bindings are a test of the bindings themselves, not of the C code
> behind the bindings. I think it is sufficient to only perform file://
> testing in the bindings tests because that will exercise the Python-to-C
> translation code in exactly the same way testing over the other RA layers would.
+1
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org