You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Ben Craig (JIRA)" <ji...@apache.org> on 2013/09/27 17:50:07 UTC
[jira] [Resolved] (THRIFT-2139) MSVC 2012 Error - Cannot compile
due to BoostThreadFactory
[ https://issues.apache.org/jira/browse/THRIFT-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ben Craig resolved THRIFT-2139.
-------------------------------
Resolution: Fixed
Fix Version/s: 0.9.2
Committed. Thanks Alex!
Minor issue for future patches. It appears you generated the diff from the lib directory. In the future, please generate the patch from the root directory.
There is one minor tradeoff with this patch that I am deeming acceptable. Building the static library now generates a linker warning that the unused thread factory doesn't have any symbols in it. I think this warning is preferable to having multiple projects, or more complicated project magic, at least for now.
> MSVC 2012 Error - Cannot compile due to BoostThreadFactory
> ----------------------------------------------------------
>
> Key: THRIFT-2139
> URL: https://issues.apache.org/jira/browse/THRIFT-2139
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.1
> Environment: MSVC 2012 x64
> Reporter: Chris Stylianou
> Priority: Blocker
> Labels: c++, msvc, thrift
> Fix For: 0.9.2
>
> Attachments: THRIFT-2139.patch
>
>
> Errors given are:
> bq.error C2664: 'std::thread::id::id(const std::thread &)' : cannot convert parameter 1 from 'boost::thread::id' to 'const std::thread &' C:\Users\chris\Desktop\workspace\build\thrift\thrift-0.9.1\lib\cpp\src\thrift\concurrency\BoostThreadFactory.cpp 101 1 libthrift
> bq.error C2664: 'std::thread::id::id(const std::thread &)' : cannot convert parameter 1 from 'boost::thread::id' to 'const std::thread &' C:\Users\chris\Desktop\workspace\build\thrift\thrift-0.9.1\lib\cpp\src\thrift\concurrency\BoostThreadFactory.cpp 165 1 libthrift
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira