[GitHub] [samza] shanthoosh commented on issue #1043: SAMZA-2202: Create log compact topic with larger message size

[GitBox <gi...@apache.org>]

shanthoosh commented on issue #1043: SAMZA-2202: Create log compact topic with larger message size
URL: https://github.com/apache/samza/pull/1043#issuecomment-494591949
 
 
   Just curious.
   
   Maximum message size accepted by a kafka broker is defined by the configuration: message.max.bytes. There're new asynchronous API's added in kafka-AdminClient which allows the users to query the broker configuration. Broker configurations can be accessed using `AdminClient.describeConfigs();` API
   
   Rather than exposing a configuration to set maximum msg-size with defaults from samza's-end, would it be beneficial to query the configured value directly once from the broker during container-startup. By that, for different kind of brokers(with different supported max-message-size), users might not have to tune this configuration correctly at samza-end.
   
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services