[GitHub] spark pull request #17027: [SPARK-19650] Commands should not trigger a Spark...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17027#discussion_r103050183
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
    @@ -175,19 +175,14 @@ class Dataset[T] private[sql](
       }
     
       @transient private[sql] val logicalPlan: LogicalPlan = {
    -    def hasSideEffects(plan: LogicalPlan): Boolean = plan match {
    -      case _: Command |
    -           _: InsertIntoTable => true
    -      case _ => false
    -    }
    -
    +    // For various commands (like DDL) and queries with side effects, we force query execution
    +    // to happen right away to let these side effects take place eagerly.
         queryExecution.analyzed match {
           // For various commands (like DDL) and queries with side effects, we force query execution
    --- End diff --
    
    remove this line


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org