[GitHub] [superset] geido commented on a diff in pull request #21332: chore: Cypress runtime enhancements

[GitBox <gi...@apache.org>]

geido commented on code in PR #21332:
URL: https://github.com/apache/superset/pull/21332#discussion_r968193145


##########
superset-frontend/cypress-base/cypress/integration/alerts_and_reports/reports.test.ts:
##########
@@ -16,31 +16,26 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { REPORT_LIST } from './alert_report.helper';
+import { REPORT_LIST } from 'cypress/utils/urls';
 
-describe('report list view', () => {
-  beforeEach(() => {
-    cy.login();
+describe('Report list view', () => {
+  before(() => {
+    cy.visit(REPORT_LIST);
   });
 
-  afterEach(() => {
-    cy.eyesClose();
+  beforeEach(() => {
+    cy.preserveLogin();
   });
 
   it('should load report lists', () => {
-    cy.visit(REPORT_LIST);
-
-    cy.get('[data-test="listview-table"]').should('be.visible');
-    // check report list view header
-    cy.get('[data-test="sort-header"]').eq(1).contains('Last run');
-    cy.get('[data-test="sort-header"]').eq(2).contains('Name');
-    cy.get('[data-test="sort-header"]').eq(3).contains('Schedule');
-    cy.get('[data-test="sort-header"]').eq(4).contains('Notification method');
-    cy.get('[data-test="sort-header"]').eq(5).contains('Created by');
-    cy.get('[data-test="sort-header"]').eq(6).contains('Owners');
-    cy.get('[data-test="sort-header"]').eq(7).contains('Modified');
-    // TODO: this assert is flaky, we need to find a way to make it work consistenly
-    // cy.get('[data-test="sort-header"]').eq(7).contains('Active');
-    // cy.get('[data-test="sort-header"]').eq(8).contains('Actions');

Review Comment:
   Good catch. I think I just forgot to keep that comment. Cypress won't recognize that one. There is something weird going on with it. For now, I'll bring the comment back.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org