You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/02/08 02:26:03 UTC

Re: Review Request 65316: Added test for delayed authorization during operator events.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65316/
-----------------------------------------------------------

(Updated Feb. 8, 2018, 2:26 a.m.)


Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Vinod Kone.


Bugs: MESOS-8469
    https://issues.apache.org/jira/browse/MESOS-8469


Repository: mesos


Description
-------

Until the fix for MESOS-8469, it was possible for the master
operator event stream to drop events, if event-related state in
the master changed in between asynchronous calls.

This patch adds `MasterAPITest.EventAuthorizationDelayed` to
verify the fix for that issue.


Diffs
-----

  src/tests/api_tests.cpp b639a4bafbf69d3ea53aa0573e9f0489c3a1a57f 


Diff: https://reviews.apache.org/r/65316/diff/4/


Testing
-------

Confirmed that the test fails without the fix for MESOS-8469.

When the fix is included, the test passes. Successfully ran `bin/mesos-tests.sh --gtest_filter="ContentType/MasterAPITest.EventAuthorizationDelayed*" --gtest_repeat=1000 --gtest_break_on_failure` to rule out any flakiness.


Thanks,

Greg Mann