[GitHub] [incubator-inlong] luchunliang commented on a change in pull request #3174: [INLONG-3173][Sort-Standalone] Unify SortClusterConfig in manager and sort-standalone

[GitBox <gi...@apache.org>]

luchunliang commented on a change in pull request #3174:
URL: https://github.com/apache/incubator-inlong/pull/3174#discussion_r828678763



##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sort/SortClusterConfigResponse.java
##########
@@ -31,7 +31,7 @@
     String msg;
     int code;
     String md5;
-    List<SortTaskConfig> tasks;
+    SortClusterConfig data;

Review comment:
       pojo class can move to inlong-common module.
   And remove pojo class of sort-standalone module "org.apache.inlong.sort.standalone.config.pojo".
   Use same class in sort-standalone and manager.

##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sort/SortClusterConfigResponse.java
##########
@@ -43,8 +43,8 @@
     @Builder
     @Data
     public static class SortTaskConfig {
-        String taskName;
-        SinkType sinkType;
+        String name;
+        SinkType type;

Review comment:
       It is better that type is String.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org