You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/04/12 16:34:03 UTC
[GitHub] [cloudstack] slavkap opened a new pull request, #6253: Extract the IO_URING configuration into the agent.properties
slavkap opened a new pull request, #6253:
URL: https://github.com/apache/cloudstack/pull/6253
### Description
This PR fixes #6252
When using advanced virtualization, the IO Driver is not supported. The admins will decide if they want to enable/disable this configuration from `agent.properties` file. It's enabled by default
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6253: Extract the IO_URING configuration into the agent.properties
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6253:
URL: https://github.com/apache/cloudstack/pull/6253#issuecomment-1096950072
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6253: Extract the IO_URING configuration into the agent.properties
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6253:
URL: https://github.com/apache/cloudstack/pull/6253#issuecomment-1130184281
@NuxRo what would you advise as a solution? If the default value is false, administrators may be aware to update all their KVM hosts if they want to enable back IO uring, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] NuxRo commented on pull request #6253: Extract the IO_URING configuration into the agent.properties
Posted by GitBox <gi...@apache.org>.
NuxRo commented on PR #6253:
URL: https://github.com/apache/cloudstack/pull/6253#issuecomment-1130203543
@slavkap I get it, it's a sensitive lose-lose situation.
@nvazquez I looked at whether we can determine io_uring in kvm, but build parameters don't seem advertised anywhere, we could have enabled/disabled uring dynamically based on this.
The only option we have to somewhat salvage this without hurting anyone is to default to false in the agent.properties so at least new installations work out of the box. Upgrades will still break unless the admins are aware of this change and amend their config file.
On the other hand io_uring is very new and I doubt there are many users. The EL8 and EL9 user bases are probably much bigger than them.
So.. for who do we break the experience? Is it worth going to the mailing list and have a vote or somethin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6253: Extract the IO_URING configuration into the agent.properties
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6253:
URL: https://github.com/apache/cloudstack/pull/6253#issuecomment-1096985358
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6253: Extract the IO_URING configuration into the agent.properties
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6253:
URL: https://github.com/apache/cloudstack/pull/6253#issuecomment-1131322924
@rohityadavcloud good.
I am +1 on (b)
If (b) is not feasible, (a) is ok to me.
fyi, it looks io_uring will be supported since RHEL 9.1
https://bugzilla.redhat.com/show_bug.cgi?id=1947230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6253: Extract the IO_URING configuration into the agent.properties
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6253:
URL: https://github.com/apache/cloudstack/pull/6253#issuecomment-1096984049
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] NuxRo commented on pull request #6253: Extract the IO_URING configuration into the agent.properties
Posted by GitBox <gi...@apache.org>.
NuxRo commented on PR #6253:
URL: https://github.com/apache/cloudstack/pull/6253#issuecomment-1130137570
@slavkap Nice feature, but I want to voice my concern over the default value of "true".
This will out of the box _break_ Cloudstack upgrades as well as new installations.
To my knowledge this affects the following platforms: EL8, EL9, current Debian Stable & Opensuse Leap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6253: Extract the IO_URING configuration into the agent.properties
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6253:
URL: https://github.com/apache/cloudstack/pull/6253#issuecomment-1130506581
@NuxRo
can we enable io_uring for Ubuntu (and suse 15 if io_uring is supported as well) and disable it for other OSes (EL, CentOS, etc) ?
@GabrielBrascher @wido
are you using io_uring in your platforms ? what's the OS and libvirt/qemu version ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6253: Extract the IO_URING configuration into the agent.properties
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6253:
URL: https://github.com/apache/cloudstack/pull/6253#issuecomment-1096949419
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6253: Extract the IO_URING configuration into the agent.properties
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6253:
URL: https://github.com/apache/cloudstack/pull/6253#issuecomment-1131216926
2cents - not all supported distros have io_uring available, having the feature enabled by default breaks the general ACS+kvm deployment. If this is a relatively new feature this should ship as (a) disabled by default and to be enabled on per-host basis via agent.properties by the admin, or (b) be enabled by default based on capabilities discovered by the host/agent and still enabled/disabled override by the agent.properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6253: Extract the IO_URING configuration into the agent.properties
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6253:
URL: https://github.com/apache/cloudstack/pull/6253#issuecomment-1098038798
<b>Trillian test result (tid-3886)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31565 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6253-t3886-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6253: Extract the IO_URING configuration into the agent.properties
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on PR #6253:
URL: https://github.com/apache/cloudstack/pull/6253#issuecomment-1097531959
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6253: Extract the IO_URING configuration into the agent.properties
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6253:
URL: https://github.com/apache/cloudstack/pull/6253#issuecomment-1131401804
Makes sense @weizhouapache, if (b) is not feasible then we should not enable io_uring by default and let it be overriden via agent.properties and document in release notes for 4.17 that on upgrade people using it need to update it on per-host basis.
/cc @GabrielBrascher @slavkap @wido
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on pull request #6253: Extract the IO_URING configuration into the agent.properties
Posted by GitBox <gi...@apache.org>.
slavkap commented on PR #6253:
URL: https://github.com/apache/cloudstack/pull/6253#issuecomment-1130158969
Thanks, @NuxRo, for your comment! You're right, but the reason to set the default value to `true` was for the users already using this functionality. And I didn't want to break something for them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6253: Extract the IO_URING configuration into the agent.properties
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6253:
URL: https://github.com/apache/cloudstack/pull/6253#issuecomment-1097532507
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #6253: Extract the IO_URING configuration into the agent.properties
Posted by GitBox <gi...@apache.org>.
nvazquez merged PR #6253:
URL: https://github.com/apache/cloudstack/pull/6253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org