You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/15 16:35:56 UTC
[GitHub] [superset] kgabryje commented on a change in pull request #17766: fix: Remove positions from json_metadata
kgabryje commented on a change in pull request #17766:
URL: https://github.com/apache/superset/pull/17766#discussion_r769796293
##########
File path: superset/dashboards/dao.py
##########
@@ -238,6 +238,8 @@ def set_dash_metadata( # pylint: disable=too-many-locals
if int(key) in slice_ids
}
md["default_filters"] = json.dumps(applicable_filters)
+ # positions have its own column, no need to store it in metadata
+ md.pop("positions", None)
Review comment:
Maybe we should do a migartion instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org