You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by Alessandro Presta <al...@fb.com> on 2013/05/03 20:16:28 UTC
Re: Review Request: GIRAPH-639: Add support for multiple Vertex/Edge inputs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10564/#review20126
-----------------------------------------------------------

Ship it!


Ship It!

- Alessandro Presta


On May 1, 2013, 6:31 p.m., Maja Kabiljo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10564/
> -----------------------------------------------------------
> 
> (Updated May 1, 2013, 6:31 p.m.)
> 
> 
> Review request for giraph.
> 
> 
> Description
> -------
> 
> For now, I did this only for Edge input, once I get some feedback I'll do the exactly same thing for vertex input.
> Also, I added direct support only to HiveGiraphRunner, we can extend it later to others as well.
> 
> 
> This addresses bug GIRAPH-639.
>     https://issues.apache.org/jira/browse/GIRAPH-639
> 
> 
> Diffs
> -----
> 
>   giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 795cd0c 
>   giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java f5a926f 
>   giraph-core/src/main/java/org/apache/giraph/io/EdgeInputFormat.java 2aac1f0 
>   giraph-core/src/main/java/org/apache/giraph/io/GiraphInputFormat.java 13efc93 
>   giraph-core/src/main/java/org/apache/giraph/io/VertexInputFormat.java c4d7fe2 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/multi/EdgeInputFormatDescription.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/multi/InputFormatDescription.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/multi/InputSplitWithInputFormatIndex.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/multi/MultiEdgeInputFormat.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/multi/MultiInputUtils.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/multi/MultiVertexInputFormat.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/multi/VertexInputFormatDescription.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/io/formats/multi/package-info.java PRE-CREATION 
>   giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedEdgeInputFormat.java 9b14727 
>   giraph-core/src/main/java/org/apache/giraph/io/internal/WrappedVertexInputFormat.java 4f0cfea 
>   giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java 2c1a679 
>   giraph-core/src/main/java/org/apache/giraph/worker/BspServiceWorker.java 01937ab 
>   giraph-core/src/main/java/org/apache/giraph/worker/EdgeInputSplitsCallable.java de1e774 
>   giraph-core/src/main/java/org/apache/giraph/worker/EdgeInputSplitsCallableFactory.java 4a1705b 
>   giraph-core/src/main/java/org/apache/giraph/worker/InputSplitsCallable.java a3a9ab7 
>   giraph-core/src/main/java/org/apache/giraph/worker/VertexInputSplitsCallable.java 224856e 
>   giraph-core/src/main/java/org/apache/giraph/worker/VertexInputSplitsCallableFactory.java 4eff3b8 
>   giraph-hive/src/main/java/org/apache/giraph/hive/HiveGiraphRunner.java 8d67c1d 
> 
> Diff: https://reviews.apache.org/r/10564/diff/
> 
> 
> Testing
> -------
> 
> mvn clean verify
> Run application with two edge input tables - verified results.
> 
> 
> Thanks,
> 
> Maja Kabiljo
> 
>