You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/09 00:40:57 UTC
[GitHub] [spark] HeartSaVioR edited a comment on issue #25853:
[SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer
HeartSaVioR edited a comment on issue #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer
URL: https://github.com/apache/spark/pull/25853#issuecomment-563018231
I think the major problem is actually the timeout policy (sure it is not the only problem) - it's very weird to use "last access time + interval" as "time to live" as producer will be borrowed by tasks and being used until tasks return to the cache/pool. It should be "last returned time + interval", maybe "last returned time where reference count goes 0 + interval" considering reference count. That means, we may have to reimplement the cache logic regardless of reverting this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org