You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/05/01 14:47:22 UTC
[09/24] hbase-site git commit: Published site at
7790ab156eabbea4527ec8e5a1c39430398bed0c.
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/40477ee9/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/UnassignProcedure.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/UnassignProcedure.html b/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/UnassignProcedure.html
index 824f8c3..ca94fbc 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/UnassignProcedure.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/master/assignment/UnassignProcedure.html
@@ -161,154 +161,160 @@
<span class="sourceLineNo">153</span> if (removeAfterUnassigning) {<a name="line.153"></a>
<span class="sourceLineNo">154</span> state.setRemoveAfterUnassigning(true);<a name="line.154"></a>
<span class="sourceLineNo">155</span> }<a name="line.155"></a>
-<span class="sourceLineNo">156</span> serializer.serialize(state.build());<a name="line.156"></a>
-<span class="sourceLineNo">157</span> }<a name="line.157"></a>
-<span class="sourceLineNo">158</span><a name="line.158"></a>
-<span class="sourceLineNo">159</span> @Override<a name="line.159"></a>
-<span class="sourceLineNo">160</span> protected void deserializeStateData(ProcedureStateSerializer serializer)<a name="line.160"></a>
-<span class="sourceLineNo">161</span> throws IOException {<a name="line.161"></a>
-<span class="sourceLineNo">162</span> final UnassignRegionStateData state =<a name="line.162"></a>
-<span class="sourceLineNo">163</span> serializer.deserialize(UnassignRegionStateData.class);<a name="line.163"></a>
-<span class="sourceLineNo">164</span> setTransitionState(state.getTransitionState());<a name="line.164"></a>
-<span class="sourceLineNo">165</span> setRegionInfo(ProtobufUtil.toRegionInfo(state.getRegionInfo()));<a name="line.165"></a>
-<span class="sourceLineNo">166</span> this.hostingServer = ProtobufUtil.toServerName(state.getHostingServer());<a name="line.166"></a>
-<span class="sourceLineNo">167</span> force = state.getForce();<a name="line.167"></a>
-<span class="sourceLineNo">168</span> if (state.hasDestinationServer()) {<a name="line.168"></a>
-<span class="sourceLineNo">169</span> this.destinationServer = ProtobufUtil.toServerName(state.getDestinationServer());<a name="line.169"></a>
-<span class="sourceLineNo">170</span> }<a name="line.170"></a>
-<span class="sourceLineNo">171</span> removeAfterUnassigning = state.getRemoveAfterUnassigning();<a name="line.171"></a>
-<span class="sourceLineNo">172</span> }<a name="line.172"></a>
-<span class="sourceLineNo">173</span><a name="line.173"></a>
-<span class="sourceLineNo">174</span> @Override<a name="line.174"></a>
-<span class="sourceLineNo">175</span> protected boolean startTransition(final MasterProcedureEnv env, final RegionStateNode regionNode) {<a name="line.175"></a>
-<span class="sourceLineNo">176</span> // nothing to do here. we skip the step in the constructor<a name="line.176"></a>
-<span class="sourceLineNo">177</span> // by jumping to REGION_TRANSITION_DISPATCH<a name="line.177"></a>
-<span class="sourceLineNo">178</span> throw new UnsupportedOperationException();<a name="line.178"></a>
-<span class="sourceLineNo">179</span> }<a name="line.179"></a>
-<span class="sourceLineNo">180</span><a name="line.180"></a>
-<span class="sourceLineNo">181</span> @Override<a name="line.181"></a>
-<span class="sourceLineNo">182</span> protected boolean updateTransition(final MasterProcedureEnv env, final RegionStateNode regionNode)<a name="line.182"></a>
-<span class="sourceLineNo">183</span> throws IOException {<a name="line.183"></a>
-<span class="sourceLineNo">184</span> // if the region is already closed or offline we can't do much...<a name="line.184"></a>
-<span class="sourceLineNo">185</span> if (regionNode.isInState(State.CLOSED, State.OFFLINE)) {<a name="line.185"></a>
-<span class="sourceLineNo">186</span> LOG.info("Not unassigned " + this + "; " + regionNode.toShortString());<a name="line.186"></a>
-<span class="sourceLineNo">187</span> return false;<a name="line.187"></a>
-<span class="sourceLineNo">188</span> }<a name="line.188"></a>
-<span class="sourceLineNo">189</span><a name="line.189"></a>
-<span class="sourceLineNo">190</span> // if we haven't started the operation yet, we can abort<a name="line.190"></a>
-<span class="sourceLineNo">191</span> if (aborted.get() && regionNode.isInState(State.OPEN)) {<a name="line.191"></a>
-<span class="sourceLineNo">192</span> setAbortFailure(getClass().getSimpleName(), "abort requested");<a name="line.192"></a>
+<span class="sourceLineNo">156</span> if (getAttempt() > 0) {<a name="line.156"></a>
+<span class="sourceLineNo">157</span> state.setAttempt(getAttempt());<a name="line.157"></a>
+<span class="sourceLineNo">158</span> }<a name="line.158"></a>
+<span class="sourceLineNo">159</span> serializer.serialize(state.build());<a name="line.159"></a>
+<span class="sourceLineNo">160</span> }<a name="line.160"></a>
+<span class="sourceLineNo">161</span><a name="line.161"></a>
+<span class="sourceLineNo">162</span> @Override<a name="line.162"></a>
+<span class="sourceLineNo">163</span> protected void deserializeStateData(ProcedureStateSerializer serializer)<a name="line.163"></a>
+<span class="sourceLineNo">164</span> throws IOException {<a name="line.164"></a>
+<span class="sourceLineNo">165</span> final UnassignRegionStateData state =<a name="line.165"></a>
+<span class="sourceLineNo">166</span> serializer.deserialize(UnassignRegionStateData.class);<a name="line.166"></a>
+<span class="sourceLineNo">167</span> setTransitionState(state.getTransitionState());<a name="line.167"></a>
+<span class="sourceLineNo">168</span> setRegionInfo(ProtobufUtil.toRegionInfo(state.getRegionInfo()));<a name="line.168"></a>
+<span class="sourceLineNo">169</span> this.hostingServer = ProtobufUtil.toServerName(state.getHostingServer());<a name="line.169"></a>
+<span class="sourceLineNo">170</span> force = state.getForce();<a name="line.170"></a>
+<span class="sourceLineNo">171</span> if (state.hasDestinationServer()) {<a name="line.171"></a>
+<span class="sourceLineNo">172</span> this.destinationServer = ProtobufUtil.toServerName(state.getDestinationServer());<a name="line.172"></a>
+<span class="sourceLineNo">173</span> }<a name="line.173"></a>
+<span class="sourceLineNo">174</span> removeAfterUnassigning = state.getRemoveAfterUnassigning();<a name="line.174"></a>
+<span class="sourceLineNo">175</span> if (state.hasAttempt()) {<a name="line.175"></a>
+<span class="sourceLineNo">176</span> setAttempt(state.getAttempt());<a name="line.176"></a>
+<span class="sourceLineNo">177</span> }<a name="line.177"></a>
+<span class="sourceLineNo">178</span> }<a name="line.178"></a>
+<span class="sourceLineNo">179</span><a name="line.179"></a>
+<span class="sourceLineNo">180</span> @Override<a name="line.180"></a>
+<span class="sourceLineNo">181</span> protected boolean startTransition(final MasterProcedureEnv env, final RegionStateNode regionNode) {<a name="line.181"></a>
+<span class="sourceLineNo">182</span> // nothing to do here. we skip the step in the constructor<a name="line.182"></a>
+<span class="sourceLineNo">183</span> // by jumping to REGION_TRANSITION_DISPATCH<a name="line.183"></a>
+<span class="sourceLineNo">184</span> throw new UnsupportedOperationException();<a name="line.184"></a>
+<span class="sourceLineNo">185</span> }<a name="line.185"></a>
+<span class="sourceLineNo">186</span><a name="line.186"></a>
+<span class="sourceLineNo">187</span> @Override<a name="line.187"></a>
+<span class="sourceLineNo">188</span> protected boolean updateTransition(final MasterProcedureEnv env, final RegionStateNode regionNode)<a name="line.188"></a>
+<span class="sourceLineNo">189</span> throws IOException {<a name="line.189"></a>
+<span class="sourceLineNo">190</span> // if the region is already closed or offline we can't do much...<a name="line.190"></a>
+<span class="sourceLineNo">191</span> if (regionNode.isInState(State.CLOSED, State.OFFLINE)) {<a name="line.191"></a>
+<span class="sourceLineNo">192</span> LOG.info("Not unassigned " + this + "; " + regionNode.toShortString());<a name="line.192"></a>
<span class="sourceLineNo">193</span> return false;<a name="line.193"></a>
<span class="sourceLineNo">194</span> }<a name="line.194"></a>
<span class="sourceLineNo">195</span><a name="line.195"></a>
-<span class="sourceLineNo">196</span> // Mark the region as CLOSING.<a name="line.196"></a>
-<span class="sourceLineNo">197</span> env.getAssignmentManager().markRegionAsClosing(regionNode);<a name="line.197"></a>
-<span class="sourceLineNo">198</span><a name="line.198"></a>
-<span class="sourceLineNo">199</span> // Add the close region operation the the server dispatch queue.<a name="line.199"></a>
-<span class="sourceLineNo">200</span> if (!addToRemoteDispatcher(env, regionNode.getRegionLocation())) {<a name="line.200"></a>
-<span class="sourceLineNo">201</span> // If addToRemoteDispatcher fails, it calls the callback #remoteCallFailed.<a name="line.201"></a>
-<span class="sourceLineNo">202</span> }<a name="line.202"></a>
-<span class="sourceLineNo">203</span><a name="line.203"></a>
-<span class="sourceLineNo">204</span> // Return true to keep the procedure running.<a name="line.204"></a>
-<span class="sourceLineNo">205</span> return true;<a name="line.205"></a>
-<span class="sourceLineNo">206</span> }<a name="line.206"></a>
-<span class="sourceLineNo">207</span><a name="line.207"></a>
-<span class="sourceLineNo">208</span> @Override<a name="line.208"></a>
-<span class="sourceLineNo">209</span> protected void finishTransition(final MasterProcedureEnv env, final RegionStateNode regionNode)<a name="line.209"></a>
-<span class="sourceLineNo">210</span> throws IOException {<a name="line.210"></a>
-<span class="sourceLineNo">211</span> AssignmentManager am = env.getAssignmentManager();<a name="line.211"></a>
-<span class="sourceLineNo">212</span> RegionInfo regionInfo = getRegionInfo();<a name="line.212"></a>
+<span class="sourceLineNo">196</span> // if we haven't started the operation yet, we can abort<a name="line.196"></a>
+<span class="sourceLineNo">197</span> if (aborted.get() && regionNode.isInState(State.OPEN)) {<a name="line.197"></a>
+<span class="sourceLineNo">198</span> setAbortFailure(getClass().getSimpleName(), "abort requested");<a name="line.198"></a>
+<span class="sourceLineNo">199</span> return false;<a name="line.199"></a>
+<span class="sourceLineNo">200</span> }<a name="line.200"></a>
+<span class="sourceLineNo">201</span><a name="line.201"></a>
+<span class="sourceLineNo">202</span> // Mark the region as CLOSING.<a name="line.202"></a>
+<span class="sourceLineNo">203</span> env.getAssignmentManager().markRegionAsClosing(regionNode);<a name="line.203"></a>
+<span class="sourceLineNo">204</span><a name="line.204"></a>
+<span class="sourceLineNo">205</span> // Add the close region operation the the server dispatch queue.<a name="line.205"></a>
+<span class="sourceLineNo">206</span> if (!addToRemoteDispatcher(env, regionNode.getRegionLocation())) {<a name="line.206"></a>
+<span class="sourceLineNo">207</span> // If addToRemoteDispatcher fails, it calls the callback #remoteCallFailed.<a name="line.207"></a>
+<span class="sourceLineNo">208</span> }<a name="line.208"></a>
+<span class="sourceLineNo">209</span><a name="line.209"></a>
+<span class="sourceLineNo">210</span> // Return true to keep the procedure running.<a name="line.210"></a>
+<span class="sourceLineNo">211</span> return true;<a name="line.211"></a>
+<span class="sourceLineNo">212</span> }<a name="line.212"></a>
<span class="sourceLineNo">213</span><a name="line.213"></a>
-<span class="sourceLineNo">214</span> if (!removeAfterUnassigning) {<a name="line.214"></a>
-<span class="sourceLineNo">215</span> am.markRegionAsClosed(regionNode);<a name="line.215"></a>
-<span class="sourceLineNo">216</span> } else {<a name="line.216"></a>
-<span class="sourceLineNo">217</span> // Remove from in-memory states<a name="line.217"></a>
-<span class="sourceLineNo">218</span> am.getRegionStates().deleteRegion(regionInfo);<a name="line.218"></a>
-<span class="sourceLineNo">219</span> env.getMasterServices().getServerManager().removeRegion(regionInfo);<a name="line.219"></a>
-<span class="sourceLineNo">220</span> FavoredNodesManager fnm = env.getMasterServices().getFavoredNodesManager();<a name="line.220"></a>
-<span class="sourceLineNo">221</span> if (fnm != null) {<a name="line.221"></a>
-<span class="sourceLineNo">222</span> fnm.deleteFavoredNodesForRegions(Lists.newArrayList(regionInfo));<a name="line.222"></a>
-<span class="sourceLineNo">223</span> }<a name="line.223"></a>
-<span class="sourceLineNo">224</span> }<a name="line.224"></a>
-<span class="sourceLineNo">225</span> }<a name="line.225"></a>
-<span class="sourceLineNo">226</span><a name="line.226"></a>
-<span class="sourceLineNo">227</span> @Override<a name="line.227"></a>
-<span class="sourceLineNo">228</span> public RemoteOperation remoteCallBuild(final MasterProcedureEnv env, final ServerName serverName) {<a name="line.228"></a>
-<span class="sourceLineNo">229</span> assert serverName.equals(getRegionState(env).getRegionLocation());<a name="line.229"></a>
-<span class="sourceLineNo">230</span> return new RegionCloseOperation(this, getRegionInfo(), this.destinationServer);<a name="line.230"></a>
+<span class="sourceLineNo">214</span> @Override<a name="line.214"></a>
+<span class="sourceLineNo">215</span> protected void finishTransition(final MasterProcedureEnv env, final RegionStateNode regionNode)<a name="line.215"></a>
+<span class="sourceLineNo">216</span> throws IOException {<a name="line.216"></a>
+<span class="sourceLineNo">217</span> AssignmentManager am = env.getAssignmentManager();<a name="line.217"></a>
+<span class="sourceLineNo">218</span> RegionInfo regionInfo = getRegionInfo();<a name="line.218"></a>
+<span class="sourceLineNo">219</span><a name="line.219"></a>
+<span class="sourceLineNo">220</span> if (!removeAfterUnassigning) {<a name="line.220"></a>
+<span class="sourceLineNo">221</span> am.markRegionAsClosed(regionNode);<a name="line.221"></a>
+<span class="sourceLineNo">222</span> } else {<a name="line.222"></a>
+<span class="sourceLineNo">223</span> // Remove from in-memory states<a name="line.223"></a>
+<span class="sourceLineNo">224</span> am.getRegionStates().deleteRegion(regionInfo);<a name="line.224"></a>
+<span class="sourceLineNo">225</span> env.getMasterServices().getServerManager().removeRegion(regionInfo);<a name="line.225"></a>
+<span class="sourceLineNo">226</span> FavoredNodesManager fnm = env.getMasterServices().getFavoredNodesManager();<a name="line.226"></a>
+<span class="sourceLineNo">227</span> if (fnm != null) {<a name="line.227"></a>
+<span class="sourceLineNo">228</span> fnm.deleteFavoredNodesForRegions(Lists.newArrayList(regionInfo));<a name="line.228"></a>
+<span class="sourceLineNo">229</span> }<a name="line.229"></a>
+<span class="sourceLineNo">230</span> }<a name="line.230"></a>
<span class="sourceLineNo">231</span> }<a name="line.231"></a>
<span class="sourceLineNo">232</span><a name="line.232"></a>
<span class="sourceLineNo">233</span> @Override<a name="line.233"></a>
-<span class="sourceLineNo">234</span> protected void reportTransition(final MasterProcedureEnv env, final RegionStateNode regionNode,<a name="line.234"></a>
-<span class="sourceLineNo">235</span> final TransitionCode code, final long seqId) throws UnexpectedStateException {<a name="line.235"></a>
-<span class="sourceLineNo">236</span> switch (code) {<a name="line.236"></a>
-<span class="sourceLineNo">237</span> case CLOSED:<a name="line.237"></a>
-<span class="sourceLineNo">238</span> setTransitionState(RegionTransitionState.REGION_TRANSITION_FINISH);<a name="line.238"></a>
-<span class="sourceLineNo">239</span> break;<a name="line.239"></a>
-<span class="sourceLineNo">240</span> default:<a name="line.240"></a>
-<span class="sourceLineNo">241</span> throw new UnexpectedStateException(String.format(<a name="line.241"></a>
-<span class="sourceLineNo">242</span> "Received report unexpected transition state=%s for region=%s server=%s, expected CLOSED.",<a name="line.242"></a>
-<span class="sourceLineNo">243</span> code, regionNode.getRegionInfo(), regionNode.getRegionLocation()));<a name="line.243"></a>
-<span class="sourceLineNo">244</span> }<a name="line.244"></a>
-<span class="sourceLineNo">245</span> }<a name="line.245"></a>
-<span class="sourceLineNo">246</span><a name="line.246"></a>
-<span class="sourceLineNo">247</span> @Override<a name="line.247"></a>
-<span class="sourceLineNo">248</span> protected boolean remoteCallFailed(final MasterProcedureEnv env, final RegionStateNode regionNode,<a name="line.248"></a>
-<span class="sourceLineNo">249</span> final IOException exception) {<a name="line.249"></a>
-<span class="sourceLineNo">250</span> // TODO: Is there on-going rpc to cleanup?<a name="line.250"></a>
-<span class="sourceLineNo">251</span> if (exception instanceof ServerCrashException) {<a name="line.251"></a>
-<span class="sourceLineNo">252</span> // This exception comes from ServerCrashProcedure AFTER log splitting.<a name="line.252"></a>
-<span class="sourceLineNo">253</span> // SCP found this region as a RIT. Its call into here says it is ok to let this procedure go<a name="line.253"></a>
-<span class="sourceLineNo">254</span> // complete. This complete will release lock on this region so subsequent action on region<a name="line.254"></a>
-<span class="sourceLineNo">255</span> // can succeed; e.g. the assign that follows this unassign when a move (w/o wait on SCP<a name="line.255"></a>
-<span class="sourceLineNo">256</span> // the assign could run w/o logs being split so data loss).<a name="line.256"></a>
-<span class="sourceLineNo">257</span> try {<a name="line.257"></a>
-<span class="sourceLineNo">258</span> reportTransition(env, regionNode, TransitionCode.CLOSED, HConstants.NO_SEQNUM);<a name="line.258"></a>
-<span class="sourceLineNo">259</span> } catch (UnexpectedStateException e) {<a name="line.259"></a>
-<span class="sourceLineNo">260</span> // Should never happen.<a name="line.260"></a>
-<span class="sourceLineNo">261</span> throw new RuntimeException(e);<a name="line.261"></a>
-<span class="sourceLineNo">262</span> }<a name="line.262"></a>
-<span class="sourceLineNo">263</span> } else if (exception instanceof RegionServerAbortedException ||<a name="line.263"></a>
-<span class="sourceLineNo">264</span> exception instanceof RegionServerStoppedException ||<a name="line.264"></a>
-<span class="sourceLineNo">265</span> exception instanceof ServerNotRunningYetException) {<a name="line.265"></a>
-<span class="sourceLineNo">266</span> // RS is aborting, we cannot offline the region since the region may need to do WAL<a name="line.266"></a>
-<span class="sourceLineNo">267</span> // recovery. Until we see the RS expiration, we should retry.<a name="line.267"></a>
-<span class="sourceLineNo">268</span> // TODO: This should be suspend like the below where we call expire on server?<a name="line.268"></a>
-<span class="sourceLineNo">269</span> LOG.info("Ignoring; waiting on ServerCrashProcedure", exception);<a name="line.269"></a>
-<span class="sourceLineNo">270</span> } else if (exception instanceof NotServingRegionException) {<a name="line.270"></a>
-<span class="sourceLineNo">271</span> LOG.info("IS THIS OK? ANY LOGS TO REPLAY; ACTING AS THOUGH ALL GOOD " + regionNode,<a name="line.271"></a>
-<span class="sourceLineNo">272</span> exception);<a name="line.272"></a>
-<span class="sourceLineNo">273</span> setTransitionState(RegionTransitionState.REGION_TRANSITION_FINISH);<a name="line.273"></a>
-<span class="sourceLineNo">274</span> } else {<a name="line.274"></a>
-<span class="sourceLineNo">275</span> LOG.warn("Expiring server " + this + "; " + regionNode.toShortString() +<a name="line.275"></a>
-<span class="sourceLineNo">276</span> ", exception=" + exception);<a name="line.276"></a>
-<span class="sourceLineNo">277</span> env.getMasterServices().getServerManager().expireServer(regionNode.getRegionLocation());<a name="line.277"></a>
-<span class="sourceLineNo">278</span> // Return false so this procedure stays in suspended state. It will be woken up by the<a name="line.278"></a>
-<span class="sourceLineNo">279</span> // ServerCrashProcedure that was scheduled when we called #expireServer above. SCP calls<a name="line.279"></a>
-<span class="sourceLineNo">280</span> // #handleRIT which will call this method only the exception will be a ServerCrashException<a name="line.280"></a>
-<span class="sourceLineNo">281</span> // this time around (See above).<a name="line.281"></a>
-<span class="sourceLineNo">282</span> // TODO: Add a SCP as a new subprocedure that we now come to depend on.<a name="line.282"></a>
-<span class="sourceLineNo">283</span> return false;<a name="line.283"></a>
-<span class="sourceLineNo">284</span> }<a name="line.284"></a>
-<span class="sourceLineNo">285</span> return true;<a name="line.285"></a>
-<span class="sourceLineNo">286</span> }<a name="line.286"></a>
-<span class="sourceLineNo">287</span><a name="line.287"></a>
-<span class="sourceLineNo">288</span> @Override<a name="line.288"></a>
-<span class="sourceLineNo">289</span> public void toStringClassDetails(StringBuilder sb) {<a name="line.289"></a>
-<span class="sourceLineNo">290</span> super.toStringClassDetails(sb);<a name="line.290"></a>
-<span class="sourceLineNo">291</span> sb.append(", server=").append(this.hostingServer);<a name="line.291"></a>
+<span class="sourceLineNo">234</span> public RemoteOperation remoteCallBuild(final MasterProcedureEnv env, final ServerName serverName) {<a name="line.234"></a>
+<span class="sourceLineNo">235</span> assert serverName.equals(getRegionState(env).getRegionLocation());<a name="line.235"></a>
+<span class="sourceLineNo">236</span> return new RegionCloseOperation(this, getRegionInfo(), this.destinationServer);<a name="line.236"></a>
+<span class="sourceLineNo">237</span> }<a name="line.237"></a>
+<span class="sourceLineNo">238</span><a name="line.238"></a>
+<span class="sourceLineNo">239</span> @Override<a name="line.239"></a>
+<span class="sourceLineNo">240</span> protected void reportTransition(final MasterProcedureEnv env, final RegionStateNode regionNode,<a name="line.240"></a>
+<span class="sourceLineNo">241</span> final TransitionCode code, final long seqId) throws UnexpectedStateException {<a name="line.241"></a>
+<span class="sourceLineNo">242</span> switch (code) {<a name="line.242"></a>
+<span class="sourceLineNo">243</span> case CLOSED:<a name="line.243"></a>
+<span class="sourceLineNo">244</span> setTransitionState(RegionTransitionState.REGION_TRANSITION_FINISH);<a name="line.244"></a>
+<span class="sourceLineNo">245</span> break;<a name="line.245"></a>
+<span class="sourceLineNo">246</span> default:<a name="line.246"></a>
+<span class="sourceLineNo">247</span> throw new UnexpectedStateException(String.format(<a name="line.247"></a>
+<span class="sourceLineNo">248</span> "Received report unexpected transition state=%s for region=%s server=%s, expected CLOSED.",<a name="line.248"></a>
+<span class="sourceLineNo">249</span> code, regionNode.getRegionInfo(), regionNode.getRegionLocation()));<a name="line.249"></a>
+<span class="sourceLineNo">250</span> }<a name="line.250"></a>
+<span class="sourceLineNo">251</span> }<a name="line.251"></a>
+<span class="sourceLineNo">252</span><a name="line.252"></a>
+<span class="sourceLineNo">253</span> @Override<a name="line.253"></a>
+<span class="sourceLineNo">254</span> protected boolean remoteCallFailed(final MasterProcedureEnv env, final RegionStateNode regionNode,<a name="line.254"></a>
+<span class="sourceLineNo">255</span> final IOException exception) {<a name="line.255"></a>
+<span class="sourceLineNo">256</span> // TODO: Is there on-going rpc to cleanup?<a name="line.256"></a>
+<span class="sourceLineNo">257</span> if (exception instanceof ServerCrashException) {<a name="line.257"></a>
+<span class="sourceLineNo">258</span> // This exception comes from ServerCrashProcedure AFTER log splitting.<a name="line.258"></a>
+<span class="sourceLineNo">259</span> // SCP found this region as a RIT. Its call into here says it is ok to let this procedure go<a name="line.259"></a>
+<span class="sourceLineNo">260</span> // complete. This complete will release lock on this region so subsequent action on region<a name="line.260"></a>
+<span class="sourceLineNo">261</span> // can succeed; e.g. the assign that follows this unassign when a move (w/o wait on SCP<a name="line.261"></a>
+<span class="sourceLineNo">262</span> // the assign could run w/o logs being split so data loss).<a name="line.262"></a>
+<span class="sourceLineNo">263</span> try {<a name="line.263"></a>
+<span class="sourceLineNo">264</span> reportTransition(env, regionNode, TransitionCode.CLOSED, HConstants.NO_SEQNUM);<a name="line.264"></a>
+<span class="sourceLineNo">265</span> } catch (UnexpectedStateException e) {<a name="line.265"></a>
+<span class="sourceLineNo">266</span> // Should never happen.<a name="line.266"></a>
+<span class="sourceLineNo">267</span> throw new RuntimeException(e);<a name="line.267"></a>
+<span class="sourceLineNo">268</span> }<a name="line.268"></a>
+<span class="sourceLineNo">269</span> } else if (exception instanceof RegionServerAbortedException ||<a name="line.269"></a>
+<span class="sourceLineNo">270</span> exception instanceof RegionServerStoppedException ||<a name="line.270"></a>
+<span class="sourceLineNo">271</span> exception instanceof ServerNotRunningYetException) {<a name="line.271"></a>
+<span class="sourceLineNo">272</span> // RS is aborting, we cannot offline the region since the region may need to do WAL<a name="line.272"></a>
+<span class="sourceLineNo">273</span> // recovery. Until we see the RS expiration, we should retry.<a name="line.273"></a>
+<span class="sourceLineNo">274</span> // TODO: This should be suspend like the below where we call expire on server?<a name="line.274"></a>
+<span class="sourceLineNo">275</span> LOG.info("Ignoring; waiting on ServerCrashProcedure", exception);<a name="line.275"></a>
+<span class="sourceLineNo">276</span> } else if (exception instanceof NotServingRegionException) {<a name="line.276"></a>
+<span class="sourceLineNo">277</span> LOG.info("IS THIS OK? ANY LOGS TO REPLAY; ACTING AS THOUGH ALL GOOD " + regionNode,<a name="line.277"></a>
+<span class="sourceLineNo">278</span> exception);<a name="line.278"></a>
+<span class="sourceLineNo">279</span> setTransitionState(RegionTransitionState.REGION_TRANSITION_FINISH);<a name="line.279"></a>
+<span class="sourceLineNo">280</span> } else {<a name="line.280"></a>
+<span class="sourceLineNo">281</span> LOG.warn("Expiring server " + this + "; " + regionNode.toShortString() +<a name="line.281"></a>
+<span class="sourceLineNo">282</span> ", exception=" + exception);<a name="line.282"></a>
+<span class="sourceLineNo">283</span> env.getMasterServices().getServerManager().expireServer(regionNode.getRegionLocation());<a name="line.283"></a>
+<span class="sourceLineNo">284</span> // Return false so this procedure stays in suspended state. It will be woken up by the<a name="line.284"></a>
+<span class="sourceLineNo">285</span> // ServerCrashProcedure that was scheduled when we called #expireServer above. SCP calls<a name="line.285"></a>
+<span class="sourceLineNo">286</span> // #handleRIT which will call this method only the exception will be a ServerCrashException<a name="line.286"></a>
+<span class="sourceLineNo">287</span> // this time around (See above).<a name="line.287"></a>
+<span class="sourceLineNo">288</span> // TODO: Add a SCP as a new subprocedure that we now come to depend on.<a name="line.288"></a>
+<span class="sourceLineNo">289</span> return false;<a name="line.289"></a>
+<span class="sourceLineNo">290</span> }<a name="line.290"></a>
+<span class="sourceLineNo">291</span> return true;<a name="line.291"></a>
<span class="sourceLineNo">292</span> }<a name="line.292"></a>
<span class="sourceLineNo">293</span><a name="line.293"></a>
<span class="sourceLineNo">294</span> @Override<a name="line.294"></a>
-<span class="sourceLineNo">295</span> public ServerName getServer(final MasterProcedureEnv env) {<a name="line.295"></a>
-<span class="sourceLineNo">296</span> return this.hostingServer;<a name="line.296"></a>
-<span class="sourceLineNo">297</span> }<a name="line.297"></a>
-<span class="sourceLineNo">298</span><a name="line.298"></a>
-<span class="sourceLineNo">299</span> @Override<a name="line.299"></a>
-<span class="sourceLineNo">300</span> protected ProcedureMetrics getProcedureMetrics(MasterProcedureEnv env) {<a name="line.300"></a>
-<span class="sourceLineNo">301</span> return env.getAssignmentManager().getAssignmentManagerMetrics().getUnassignProcMetrics();<a name="line.301"></a>
-<span class="sourceLineNo">302</span> }<a name="line.302"></a>
-<span class="sourceLineNo">303</span>}<a name="line.303"></a>
+<span class="sourceLineNo">295</span> public void toStringClassDetails(StringBuilder sb) {<a name="line.295"></a>
+<span class="sourceLineNo">296</span> super.toStringClassDetails(sb);<a name="line.296"></a>
+<span class="sourceLineNo">297</span> sb.append(", server=").append(this.hostingServer);<a name="line.297"></a>
+<span class="sourceLineNo">298</span> }<a name="line.298"></a>
+<span class="sourceLineNo">299</span><a name="line.299"></a>
+<span class="sourceLineNo">300</span> @Override<a name="line.300"></a>
+<span class="sourceLineNo">301</span> public ServerName getServer(final MasterProcedureEnv env) {<a name="line.301"></a>
+<span class="sourceLineNo">302</span> return this.hostingServer;<a name="line.302"></a>
+<span class="sourceLineNo">303</span> }<a name="line.303"></a>
+<span class="sourceLineNo">304</span><a name="line.304"></a>
+<span class="sourceLineNo">305</span> @Override<a name="line.305"></a>
+<span class="sourceLineNo">306</span> protected ProcedureMetrics getProcedureMetrics(MasterProcedureEnv env) {<a name="line.306"></a>
+<span class="sourceLineNo">307</span> return env.getAssignmentManager().getAssignmentManagerMetrics().getUnassignProcMetrics();<a name="line.307"></a>
+<span class="sourceLineNo">308</span> }<a name="line.308"></a>
+<span class="sourceLineNo">309</span>}<a name="line.309"></a>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/40477ee9/devapidocs/src-html/org/apache/hadoop/hbase/procedure2/DelayedProcedure.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/procedure2/DelayedProcedure.html b/devapidocs/src-html/org/apache/hadoop/hbase/procedure2/DelayedProcedure.html
index bd92c85..e16824c 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/procedure2/DelayedProcedure.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/procedure2/DelayedProcedure.html
@@ -28,12 +28,15 @@
<span class="sourceLineNo">020</span>import org.apache.hadoop.hbase.procedure2.util.DelayedUtil;<a name="line.20"></a>
<span class="sourceLineNo">021</span>import org.apache.yetus.audience.InterfaceAudience;<a name="line.21"></a>
<span class="sourceLineNo">022</span><a name="line.22"></a>
-<span class="sourceLineNo">023</span>@InterfaceAudience.Private<a name="line.23"></a>
-<span class="sourceLineNo">024</span>class DelayedProcedure extends DelayedUtil.DelayedContainerWithTimestamp<Procedure<?>> {<a name="line.24"></a>
-<span class="sourceLineNo">025</span> public DelayedProcedure(Procedure<?> procedure) {<a name="line.25"></a>
-<span class="sourceLineNo">026</span> super(procedure, procedure.getTimeoutTimestamp());<a name="line.26"></a>
-<span class="sourceLineNo">027</span> }<a name="line.27"></a>
-<span class="sourceLineNo">028</span>}<a name="line.28"></a>
+<span class="sourceLineNo">023</span>/**<a name="line.23"></a>
+<span class="sourceLineNo">024</span> * Vessel that carries a Procedure and a timeout.<a name="line.24"></a>
+<span class="sourceLineNo">025</span> */<a name="line.25"></a>
+<span class="sourceLineNo">026</span>@InterfaceAudience.Private<a name="line.26"></a>
+<span class="sourceLineNo">027</span>class DelayedProcedure extends DelayedUtil.DelayedContainerWithTimestamp<Procedure<?>> {<a name="line.27"></a>
+<span class="sourceLineNo">028</span> public DelayedProcedure(Procedure<?> procedure) {<a name="line.28"></a>
+<span class="sourceLineNo">029</span> super(procedure, procedure.getTimeoutTimestamp());<a name="line.29"></a>
+<span class="sourceLineNo">030</span> }<a name="line.30"></a>
+<span class="sourceLineNo">031</span>}<a name="line.31"></a>