[GitHub] [cordova-plugin-camera] erisu commented on a change in pull request #435: Update browser plugin

[GitBox <gi...@apache.org>]

erisu commented on a change in pull request #435: Update browser plugin
URL: https://github.com/apache/cordova-plugin-camera/pull/435#discussion_r338363796
 
 

 ##########
 File path: README.md
 ##########
 @@ -266,6 +266,10 @@ Optional parameters to customize the camera settings.
 | saveToPhotoAlbum | <code>Boolean</code> |  | Save the image to the photo album on the device after capture. |
 | popoverOptions | <code>[CameraPopoverOptions](#module_CameraPopoverOptions)</code> |  | iOS-only options that specify popover location in iPad. |
 | cameraDirection | <code>[Direction](#module_Camera.Direction)</code> | <code>BACK</code> | Choose the camera to use (front- or back-facing). |
+| customCameraContainer | <code>string</code> |  | Browser-only option, specify the id of custom camera's container element.  |
 
 Review comment:
   I believe this PR is actually no longer valid.
   
   There were some discussion after the PR creation and a decision that users should maybe use WebRTC camera functionality over this plugin. After that, this PR development was stopped. Maybe this PR can be closed.
   
   If memory serves, iOS has some limitation/problems with WebRTC camera functionality so the plugin will still be needed. It can be conditionally wrapped to decided if it use WebRTC over Plugin.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org