You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "epotyom (via GitHub)" <gi...@apache.org> on 2023/07/17 14:30:21 UTC
[GitHub] [lucene] epotyom opened a new pull request, #12445: Expression: add a set of duplicate variables
epotyom opened a new pull request, #12445:
URL: https://github.com/apache/lucene/pull/12445
Keep a set of Expression variables that are used more than once. This set can then be used by Lucene application to decide if corresponding DoubleValuesSource can benefit from caching caching.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller commented on pull request #12445: Expression: add a set of duplicate variables
Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller commented on PR #12445:
URL: https://github.com/apache/lucene/pull/12445#issuecomment-1724108149
Thanks for the idea @epotyom! I wonder if this is relevant after #12560 was merged? With that change, we now only ever evaluate any given expression argument once (within an expression). Does that solve for this problem? I think so right, but maybe I'm missing something? Thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] epotyom commented on pull request #12445: Expression: add a set of duplicate variables
Posted by "epotyom (via GitHub)" <gi...@apache.org>.
epotyom commented on PR #12445:
URL: https://github.com/apache/lucene/pull/12445#issuecomment-1724861051
@gsmiller , very nice improvement! Yes, this change is obsolete now as we only need to worry about variables reused across expressions, but not within one expression. I'll cancel this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] epotyom closed pull request #12445: Expression: add a set of duplicate variables
Posted by "epotyom (via GitHub)" <gi...@apache.org>.
epotyom closed pull request #12445: Expression: add a set of duplicate variables
URL: https://github.com/apache/lucene/pull/12445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org