You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Aishwarya Gune <ai...@confluent.io> on 2019/05/08 23:29:59 UTC
[VOTE] KIP-461 Improve Replica Fetcher behavior at handling partition failure
Hi All!
I would like to call for a vote on KIP-461 that would improve the behavior
of replica fetcher in case of partition failure. The fetcher thread would
just stop monitoring the crashed partition instead of terminating.
Here's a link to the KIP -
https://cwiki.apache.org/confluence/display/KAFKA/KIP-461+-+Improve+Replica+Fetcher+behavior+at+handling+partition+failure
Discussion thread -
https://www.mail-archive.com/dev@kafka.apache.org/msg97559.html
--
Thank you,
Aishwarya
Re: [VOTE] KIP-461 Improve Replica Fetcher behavior at handling
partition failure
Posted by Gwen Shapira <gw...@confluent.io>.
+1 (binding)
Thank you! I especially like the new metric for tracking the partitions
with errors. Its those little things :)
On Wed, May 8, 2019 at 4:30 PM Aishwarya Gune <ai...@confluent.io>
wrote:
> Hi All!
>
> I would like to call for a vote on KIP-461 that would improve the behavior
> of replica fetcher in case of partition failure. The fetcher thread would
> just stop monitoring the crashed partition instead of terminating.
>
> Here's a link to the KIP -
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-461+-+Improve+Replica+Fetcher+behavior+at+handling+partition+failure
>
> Discussion thread -
> https://www.mail-archive.com/dev@kafka.apache.org/msg97559.html
>
> --
> Thank you,
> Aishwarya
>
--
*Gwen Shapira*
Product Manager | Confluent
650.450.2760 | @gwenshap
Follow us: Twitter <https://twitter.com/ConfluentInc> | blog
<http://www.confluent.io/blog>
Re: [VOTE] KIP-461 Improve Replica Fetcher behavior at handling
partition failure
Posted by Aishwarya Gune <ai...@confluent.io>.
Yeah, will keep in mind. Thank you Colin.
On Mon, May 13, 2019 at 1:45 PM Colin McCabe <cm...@apache.org> wrote:
> On Mon, May 13, 2019, at 11:49, Aishwarya Gune wrote:
> > Thank you everyone for the discussion and voting for KIP-461
> > <
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-461+-+Improve+Replica+Fetcher+behavior+at+handling+partition+failure
> >.
> > Closing the vote on this KIP which passes with -
>
> I'm assuming that you meant to close this last week before the KIP freeze
> on Saturday. Since all the votes were made before the KIP freeze, I'm
> going to allow this into 2.3 :)
>
> > - 5 binding (Jason, Colin, Gwen, Jun, Harsha)
> > - 1 non-binding (Dhruvil)
>
> In the future you might want to write this as +5 binding. When I first
> glanced at this I saw -5 binding, which made me think of 5 -1 votes.
>
> Thanks again for the KIP.
>
> best,
> Colin
>
> >
> >
> >
> >
> > On Thu, May 9, 2019 at 10:53 AM Harsha Chintalapani <ka...@harsha.io>
> wrote:
> >
> > > Thanks for the KIP. +1(binding)
> > >
> > > Thanks,
> > > Harsha
> > > On May 9, 2019, 9:58 AM -0700, Jun Rao <ju...@confluent.io>, wrote:
> > > > Hi, Aishwarya,
> > > >
> > > > Thanks for the KIP. +1
> > > >
> > > > Jun
> > > >
> > > > On Wed, May 8, 2019 at 4:30 PM Aishwarya Gune <
> aishwarya@confluent.io>
> > > > wrote:
> > > >
> > > > > Hi All!
> > > > >
> > > > > I would like to call for a vote on KIP-461 that would improve the
> > > behavior
> > > > > of replica fetcher in case of partition failure. The fetcher thread
> > > would
> > > > > just stop monitoring the crashed partition instead of terminating.
> > > > >
> > > > > Here's a link to the KIP -
> > > > >
> > > > >
> > >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-461+-+Improve+Replica+Fetcher+behavior+at+handling+partition+failure
> > > > >
> > > > > Discussion thread -
> > > > > https://www.mail-archive.com/dev@kafka.apache.org/msg97559.html
> > > > >
> > > > > --
> > > > > Thank you,
> > > > > Aishwarya
> > > > >
> > >
> >
> >
> > --
> > Thank you,
> > Aishwarya
> >
>
--
Thank you,
Aishwarya
Re: [VOTE] KIP-461 Improve Replica Fetcher behavior at handling partition failure
Posted by Colin McCabe <cm...@apache.org>.
On Mon, May 13, 2019, at 11:49, Aishwarya Gune wrote:
> Thank you everyone for the discussion and voting for KIP-461
> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-461+-+Improve+Replica+Fetcher+behavior+at+handling+partition+failure>.
> Closing the vote on this KIP which passes with -
I'm assuming that you meant to close this last week before the KIP freeze on Saturday. Since all the votes were made before the KIP freeze, I'm going to allow this into 2.3 :)
> - 5 binding (Jason, Colin, Gwen, Jun, Harsha)
> - 1 non-binding (Dhruvil)
In the future you might want to write this as +5 binding. When I first glanced at this I saw -5 binding, which made me think of 5 -1 votes.
Thanks again for the KIP.
best,
Colin
>
>
>
>
> On Thu, May 9, 2019 at 10:53 AM Harsha Chintalapani <ka...@harsha.io> wrote:
>
> > Thanks for the KIP. +1(binding)
> >
> > Thanks,
> > Harsha
> > On May 9, 2019, 9:58 AM -0700, Jun Rao <ju...@confluent.io>, wrote:
> > > Hi, Aishwarya,
> > >
> > > Thanks for the KIP. +1
> > >
> > > Jun
> > >
> > > On Wed, May 8, 2019 at 4:30 PM Aishwarya Gune <ai...@confluent.io>
> > > wrote:
> > >
> > > > Hi All!
> > > >
> > > > I would like to call for a vote on KIP-461 that would improve the
> > behavior
> > > > of replica fetcher in case of partition failure. The fetcher thread
> > would
> > > > just stop monitoring the crashed partition instead of terminating.
> > > >
> > > > Here's a link to the KIP -
> > > >
> > > >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-461+-+Improve+Replica+Fetcher+behavior+at+handling+partition+failure
> > > >
> > > > Discussion thread -
> > > > https://www.mail-archive.com/dev@kafka.apache.org/msg97559.html
> > > >
> > > > --
> > > > Thank you,
> > > > Aishwarya
> > > >
> >
>
>
> --
> Thank you,
> Aishwarya
>
Re: [VOTE] KIP-461 Improve Replica Fetcher behavior at handling
partition failure
Posted by Aishwarya Gune <ai...@confluent.io>.
Thank you everyone for the discussion and voting for KIP-461
<https://cwiki.apache.org/confluence/display/KAFKA/KIP-461+-+Improve+Replica+Fetcher+behavior+at+handling+partition+failure>.
Closing the vote on this KIP which passes with -
- 5 binding (Jason, Colin, Gwen, Jun, Harsha)
- 1 non-binding (Dhruvil)
On Thu, May 9, 2019 at 10:53 AM Harsha Chintalapani <ka...@harsha.io> wrote:
> Thanks for the KIP. +1(binding)
>
> Thanks,
> Harsha
> On May 9, 2019, 9:58 AM -0700, Jun Rao <ju...@confluent.io>, wrote:
> > Hi, Aishwarya,
> >
> > Thanks for the KIP. +1
> >
> > Jun
> >
> > On Wed, May 8, 2019 at 4:30 PM Aishwarya Gune <ai...@confluent.io>
> > wrote:
> >
> > > Hi All!
> > >
> > > I would like to call for a vote on KIP-461 that would improve the
> behavior
> > > of replica fetcher in case of partition failure. The fetcher thread
> would
> > > just stop monitoring the crashed partition instead of terminating.
> > >
> > > Here's a link to the KIP -
> > >
> > >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-461+-+Improve+Replica+Fetcher+behavior+at+handling+partition+failure
> > >
> > > Discussion thread -
> > > https://www.mail-archive.com/dev@kafka.apache.org/msg97559.html
> > >
> > > --
> > > Thank you,
> > > Aishwarya
> > >
>
--
Thank you,
Aishwarya
Re: [VOTE] KIP-461 Improve Replica Fetcher behavior at handling
partition failure
Posted by Harsha Chintalapani <ka...@harsha.io>.
Thanks for the KIP. +1(binding)
Thanks,
Harsha
On May 9, 2019, 9:58 AM -0700, Jun Rao <ju...@confluent.io>, wrote:
> Hi, Aishwarya,
>
> Thanks for the KIP. +1
>
> Jun
>
> On Wed, May 8, 2019 at 4:30 PM Aishwarya Gune <ai...@confluent.io>
> wrote:
>
> > Hi All!
> >
> > I would like to call for a vote on KIP-461 that would improve the behavior
> > of replica fetcher in case of partition failure. The fetcher thread would
> > just stop monitoring the crashed partition instead of terminating.
> >
> > Here's a link to the KIP -
> >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-461+-+Improve+Replica+Fetcher+behavior+at+handling+partition+failure
> >
> > Discussion thread -
> > https://www.mail-archive.com/dev@kafka.apache.org/msg97559.html
> >
> > --
> > Thank you,
> > Aishwarya
> >
Re: [VOTE] KIP-461 Improve Replica Fetcher behavior at handling
partition failure
Posted by Jun Rao <ju...@confluent.io>.
Hi, Aishwarya,
Thanks for the KIP. +1
Jun
On Wed, May 8, 2019 at 4:30 PM Aishwarya Gune <ai...@confluent.io>
wrote:
> Hi All!
>
> I would like to call for a vote on KIP-461 that would improve the behavior
> of replica fetcher in case of partition failure. The fetcher thread would
> just stop monitoring the crashed partition instead of terminating.
>
> Here's a link to the KIP -
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-461+-+Improve+Replica+Fetcher+behavior+at+handling+partition+failure
>
> Discussion thread -
> https://www.mail-archive.com/dev@kafka.apache.org/msg97559.html
>
> --
> Thank you,
> Aishwarya
>
Re: [VOTE] KIP-461 Improve Replica Fetcher behavior at handling
partition failure
Posted by Dhruvil Shah <dh...@confluent.io>.
Thanks for the KIP! +1 (non-binding)
On Wed, May 8, 2019 at 10:23 PM Colin McCabe <cm...@apache.org> wrote:
> +1. Thanks, Aishwarya.
>
> Colin
>
> On Wed, May 8, 2019, at 17:50, Jason Gustafson wrote:
> > +1. Thanks!
> >
> > On Wed, May 8, 2019 at 4:30 PM Aishwarya Gune <ai...@confluent.io>
> > wrote:
> >
> > > Hi All!
> > >
> > > I would like to call for a vote on KIP-461 that would improve the
> behavior
> > > of replica fetcher in case of partition failure. The fetcher thread
> would
> > > just stop monitoring the crashed partition instead of terminating.
> > >
> > > Here's a link to the KIP -
> > >
> > >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-461+-+Improve+Replica+Fetcher+behavior+at+handling+partition+failure
> > >
> > > Discussion thread -
> > > https://www.mail-archive.com/dev@kafka.apache.org/msg97559.html
> > >
> > > --
> > > Thank you,
> > > Aishwarya
> > >
> >
>
Re: [VOTE] KIP-461 Improve Replica Fetcher behavior at handling partition failure
Posted by Colin McCabe <cm...@apache.org>.
+1. Thanks, Aishwarya.
Colin
On Wed, May 8, 2019, at 17:50, Jason Gustafson wrote:
> +1. Thanks!
>
> On Wed, May 8, 2019 at 4:30 PM Aishwarya Gune <ai...@confluent.io>
> wrote:
>
> > Hi All!
> >
> > I would like to call for a vote on KIP-461 that would improve the behavior
> > of replica fetcher in case of partition failure. The fetcher thread would
> > just stop monitoring the crashed partition instead of terminating.
> >
> > Here's a link to the KIP -
> >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-461+-+Improve+Replica+Fetcher+behavior+at+handling+partition+failure
> >
> > Discussion thread -
> > https://www.mail-archive.com/dev@kafka.apache.org/msg97559.html
> >
> > --
> > Thank you,
> > Aishwarya
> >
>
Re: [VOTE] KIP-461 Improve Replica Fetcher behavior at handling
partition failure
Posted by Jason Gustafson <ja...@confluent.io>.
+1. Thanks!
On Wed, May 8, 2019 at 4:30 PM Aishwarya Gune <ai...@confluent.io>
wrote:
> Hi All!
>
> I would like to call for a vote on KIP-461 that would improve the behavior
> of replica fetcher in case of partition failure. The fetcher thread would
> just stop monitoring the crashed partition instead of terminating.
>
> Here's a link to the KIP -
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-461+-+Improve+Replica+Fetcher+behavior+at+handling+partition+failure
>
> Discussion thread -
> https://www.mail-archive.com/dev@kafka.apache.org/msg97559.html
>
> --
> Thank you,
> Aishwarya
>