[GitHub] [superset] betodealmeida commented on a change in pull request #15620: fix: error page status codes

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #15620:
URL: https://github.com/apache/superset/pull/15620#discussion_r667187667



##########
File path: superset/views/base.py
##########
@@ -397,7 +397,7 @@ def show_http_exception(ex: HTTPException) -> FlaskResponse:
         and ex.code in {404, 500}
     ):
         path = resource_filename("superset", f"static/assets/{ex.code}.html")
-        return send_file(path)
+        return send_file(path), ex.code

Review comment:
       Good catch! Thanks for fixing!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org