You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by cl...@apache.org on 2016/06/13 18:21:25 UTC

[4/7] activemq-artemis git commit: Fix checkstyle redundant modifier violations

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageConsumerTest.java
----------------------------------------------------------------------
diff --git a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageConsumerTest.java b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageConsumerTest.java
index 45e0f3c..abd8b1e 100644
--- a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageConsumerTest.java
+++ b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageConsumerTest.java
@@ -1976,10 +1976,10 @@ public class MessageConsumerTest extends JMSTestCase {
 
       final AtomicBoolean running;
 
-      public ThreadCloser(final AtomicBoolean running,
-                          final Object waitMonitor,
-                          final long timeToSleep,
-                          final MessageConsumer topicConsumer) {
+      private ThreadCloser(final AtomicBoolean running,
+                           final Object waitMonitor,
+                           final long timeToSleep,
+                           final MessageConsumer topicConsumer) {
          this.running = running;
          this.waitMonitor = waitMonitor;
          this.timeToSleep = timeToSleep;
@@ -2024,10 +2024,10 @@ public class MessageConsumerTest extends JMSTestCase {
 
       final AtomicBoolean running;
 
-      public ThreadReceiver(final AtomicBoolean running,
-                            final Object waitMonitor,
-                            final long timeToWait,
-                            final MessageConsumer topicConsumer) {
+      private ThreadReceiver(final AtomicBoolean running,
+                             final Object waitMonitor,
+                             final long timeToWait,
+                             final MessageConsumer topicConsumer) {
          this.running = running;
          this.waitMonitor = waitMonitor;
          this.timeToWait = timeToWait;
@@ -3819,7 +3819,7 @@ public class MessageConsumerTest extends JMSTestCase {
       private CountDownLatch latch;
       private JMSException exception;
 
-      public ConnectionCloseMessageListener(Connection conn, CountDownLatch latch) {
+      private ConnectionCloseMessageListener(Connection conn, CountDownLatch latch) {
          this.conn = conn;
          this.latch = latch;
       }
@@ -3842,7 +3842,7 @@ public class MessageConsumerTest extends JMSTestCase {
       private CountDownLatch latch;
       private JMSException exception;
 
-      public ConnectionStopMessageListener(Connection conn, CountDownLatch latch) {
+      private ConnectionStopMessageListener(Connection conn, CountDownLatch latch) {
          this.conn = conn;
          this.latch = latch;
       }
@@ -3865,7 +3865,7 @@ public class MessageConsumerTest extends JMSTestCase {
       private CountDownLatch latch;
       private JMSException exception;
 
-      public SessionCloseMessageListener(Session session, CountDownLatch latch) {
+      private SessionCloseMessageListener(Session session, CountDownLatch latch) {
          this.session = session;
          this.latch = latch;
       }
@@ -3904,7 +3904,7 @@ public class MessageConsumerTest extends JMSTestCase {
          ActiveMQTestBase.waitForLatch(latch);
       }
 
-      public ExceptionRedelMessageListenerImpl(final Session sess) {
+      private ExceptionRedelMessageListenerImpl(final Session sess) {
          this.sess = sess;
       }
 
@@ -3994,7 +3994,7 @@ public class MessageConsumerTest extends JMSTestCase {
 
       private final boolean transacted;
 
-      public RedelMessageListenerImpl(final boolean transacted) {
+      private RedelMessageListenerImpl(final boolean transacted) {
          this.transacted = transacted;
       }
 
@@ -4070,11 +4070,11 @@ public class MessageConsumerTest extends JMSTestCase {
 
       private CountDownLatch latch = new CountDownLatch(1);
 
-      public MessageListenerImpl(final int count) {
+      private MessageListenerImpl(final int count) {
          latch = new CountDownLatch(count);
       }
 
-      public MessageListenerImpl() {
+      private MessageListenerImpl() {
          this(1);
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageProducerTest.java
----------------------------------------------------------------------
diff --git a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageProducerTest.java b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageProducerTest.java
index 19bb908..a9ec1c4 100644
--- a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageProducerTest.java
+++ b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MessageProducerTest.java
@@ -735,7 +735,7 @@ public class MessageProducerTest extends JMSTestCase {
       private CountDownLatch latch;
       private JMSException exception;
 
-      public CloseCompletionListener(MessageProducer p, CountDownLatch latch) {
+      private CloseCompletionListener(MessageProducer p, CountDownLatch latch) {
          this.p = p;
          this.latch = latch;
       }
@@ -762,7 +762,7 @@ public class MessageProducerTest extends JMSTestCase {
       private JMSException exception;
       private Connection conn;
 
-      public ConnectionCloseCompletionListener(Connection conn, CountDownLatch latch) {
+      private ConnectionCloseCompletionListener(Connection conn, CountDownLatch latch) {
          this.conn = conn;
          this.latch = latch;
       }
@@ -789,7 +789,7 @@ public class MessageProducerTest extends JMSTestCase {
       private JMSException exception;
       private Session session;
 
-      public SessionCloseCompletionListener(Session session, CountDownLatch latch) {
+      private SessionCloseCompletionListener(Session session, CountDownLatch latch) {
          this.session = session;
          this.latch = latch;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MiscellaneousTest.java
----------------------------------------------------------------------
diff --git a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MiscellaneousTest.java b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MiscellaneousTest.java
index 4febb3d..d2eb533 100644
--- a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MiscellaneousTest.java
+++ b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/MiscellaneousTest.java
@@ -242,7 +242,7 @@ public class MiscellaneousTest extends JMSTestCase {
 
       private boolean resultSet;
 
-      public Result() {
+      private Result() {
          success = false;
          e = null;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TransactedSessionTest.java
----------------------------------------------------------------------
diff --git a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TransactedSessionTest.java b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TransactedSessionTest.java
index b814d6e..6f31649 100644
--- a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TransactedSessionTest.java
+++ b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TransactedSessionTest.java
@@ -697,7 +697,7 @@ public class TransactedSessionTest extends JMSTestCase {
 
       private final Connection conn;
 
-      public myReceiver(CountDownLatch startLatch, Connection conn) {
+      myReceiver(CountDownLatch startLatch, Connection conn) {
          this.startLatch = startLatch;
          this.conn = conn;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageHeaderTest.java
----------------------------------------------------------------------
diff --git a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageHeaderTest.java b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageHeaderTest.java
index cbb7a9d..ad2e8d2 100644
--- a/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageHeaderTest.java
+++ b/tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/message/MessageHeaderTest.java
@@ -836,7 +836,7 @@ public class MessageHeaderTest extends MessageHeaderTestBase {
 
       private final ClientMessage message;
 
-      public FakeSession(final ClientMessage message) {
+      FakeSession(final ClientMessage message) {
          this.message = message;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/paging/MeasurePagingMultiThreadTest.java
----------------------------------------------------------------------
diff --git a/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/paging/MeasurePagingMultiThreadTest.java b/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/paging/MeasurePagingMultiThreadTest.java
index 87645b8..e19b190 100644
--- a/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/paging/MeasurePagingMultiThreadTest.java
+++ b/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/paging/MeasurePagingMultiThreadTest.java
@@ -69,7 +69,7 @@ public class MeasurePagingMultiThreadTest extends ActiveMQTestBase {
 
             Throwable e;
 
-            public Sender() throws Exception {
+            Sender() throws Exception {
                session = factory.createSession(false, true, true);
                producer = session.createProducer(adr);
                msg = session.createMessage(true);

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/sends/AbstractSendReceivePerfTest.java
----------------------------------------------------------------------
diff --git a/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/sends/AbstractSendReceivePerfTest.java b/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/sends/AbstractSendReceivePerfTest.java
index 12d6229..be8093c 100644
--- a/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/sends/AbstractSendReceivePerfTest.java
+++ b/tests/performance-tests/src/test/java/org/apache/activemq/artemis/tests/performance/sends/AbstractSendReceivePerfTest.java
@@ -126,7 +126,7 @@ public abstract class AbstractSendReceivePerfTest extends JMSTestBase {
 
       public boolean failed = false;
 
-      public MessageReceiver(String qname, long numberOfSamples) throws Exception {
+      private MessageReceiver(String qname, long numberOfSamples) throws Exception {
          super("Receiver " + qname);
          this.qName = qname;
          this.numberOfSamples = numberOfSamples;
@@ -160,7 +160,7 @@ public abstract class AbstractSendReceivePerfTest extends JMSTestBase {
 
       public boolean failed = false;
 
-      public MessageSender(String qname) throws Exception {
+      private MessageSender(String qname) throws Exception {
          super("Sender " + qname);
 
          this.qName = qname;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/journal/JournalCleanupCompactStressTest.java
----------------------------------------------------------------------
diff --git a/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/journal/JournalCleanupCompactStressTest.java b/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/journal/JournalCleanupCompactStressTest.java
index 6bd2fcf..ae2b2f1 100644
--- a/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/journal/JournalCleanupCompactStressTest.java
+++ b/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/journal/JournalCleanupCompactStressTest.java
@@ -301,7 +301,7 @@ public class JournalCleanupCompactStressTest extends ActiveMQTestBase {
 
       OperationContextImpl ctx = new OperationContextImpl(executorFactory.getExecutor());
 
-      public FastAppenderTx() {
+      FastAppenderTx() {
          super("FastAppenderTX");
       }
 
@@ -373,7 +373,7 @@ public class JournalCleanupCompactStressTest extends ActiveMQTestBase {
 
       OperationContextImpl ctx = new OperationContextImpl(executorFactory.getExecutor());
 
-      public FastUpdateTx(final LinkedBlockingDeque<Long> queue) {
+      FastUpdateTx(final LinkedBlockingDeque<Long> queue) {
          super("FastUpdateTX");
          this.queue = queue;
       }
@@ -475,7 +475,7 @@ public class JournalCleanupCompactStressTest extends ActiveMQTestBase {
     */
    class SlowAppenderNoTX extends Thread {
 
-      public SlowAppenderNoTX() {
+      SlowAppenderNoTX() {
          super("SlowAppender");
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/remote/PingStressTest.java
----------------------------------------------------------------------
diff --git a/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/remote/PingStressTest.java b/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/remote/PingStressTest.java
index 9f717bd..9af6b90 100644
--- a/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/remote/PingStressTest.java
+++ b/tests/stress-tests/src/test/java/org/apache/activemq/artemis/tests/stress/remote/PingStressTest.java
@@ -100,7 +100,7 @@ public class PingStressTest extends ActiveMQTestBase {
 
          int threadNumber;
 
-         public LocalThread(final int i) {
+         LocalThread(final int i) {
             super("LocalThread i = " + i);
             threadNumber = i;
          }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/timing-tests/src/test/java/org/apache/activemq/artemis/tests/timing/jms/bridge/impl/JMSBridgeImplTest.java
----------------------------------------------------------------------
diff --git a/tests/timing-tests/src/test/java/org/apache/activemq/artemis/tests/timing/jms/bridge/impl/JMSBridgeImplTest.java b/tests/timing-tests/src/test/java/org/apache/activemq/artemis/tests/timing/jms/bridge/impl/JMSBridgeImplTest.java
index 9b5116e..d322a1a 100644
--- a/tests/timing-tests/src/test/java/org/apache/activemq/artemis/tests/timing/jms/bridge/impl/JMSBridgeImplTest.java
+++ b/tests/timing-tests/src/test/java/org/apache/activemq/artemis/tests/timing/jms/bridge/impl/JMSBridgeImplTest.java
@@ -745,7 +745,7 @@ public class JMSBridgeImplTest extends ActiveMQTestBase {
       private final ClassLoader original;
       private final String knownClass = "com.class.only.visible.to.tccl.SomeClass";
 
-      public MockContextClassLoader(ClassLoader parent) {
+      private MockContextClassLoader(ClassLoader parent) {
          super(parent);
          original = Thread.currentThread().getContextClassLoader();
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/MultiThreadAsynchronousFileTest.java
----------------------------------------------------------------------
diff --git a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/MultiThreadAsynchronousFileTest.java b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/MultiThreadAsynchronousFileTest.java
index 6c638ae..fb0f966 100644
--- a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/MultiThreadAsynchronousFileTest.java
+++ b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/asyncio/MultiThreadAsynchronousFileTest.java
@@ -159,10 +159,10 @@ public class MultiThreadAsynchronousFileTest extends AIOTestBase {
 
       AIOSequentialFile libaio;
 
-      public ThreadProducer(final String name,
-                            final CountDownLatch latchStart,
-                            final AIOSequentialFile libaio,
-                            final boolean sync) {
+      ThreadProducer(final String name,
+                     final CountDownLatch latchStart,
+                     final AIOSequentialFile libaio,
+                     final boolean sync) {
          super(name);
          this.latchStart = latchStart;
          this.libaio = libaio;

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/paging/impl/PagingStoreImplTest.java
----------------------------------------------------------------------
diff --git a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/paging/impl/PagingStoreImplTest.java b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/paging/impl/PagingStoreImplTest.java
index 498beb4..97520f3 100644
--- a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/paging/impl/PagingStoreImplTest.java
+++ b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/paging/impl/PagingStoreImplTest.java
@@ -634,7 +634,7 @@ public class PagingStoreImplTest extends ActiveMQTestBase {
 
       class WriterThread extends Thread {
 
-         public WriterThread() {
+         WriterThread() {
             super("PageWriter");
          }
 
@@ -668,7 +668,7 @@ public class PagingStoreImplTest extends ActiveMQTestBase {
 
       class ReaderThread extends Thread {
 
-         public ReaderThread() {
+         ReaderThread() {
             super("PageReader");
          }
 
@@ -787,11 +787,11 @@ public class PagingStoreImplTest extends ActiveMQTestBase {
 
       final SequentialFileFactory factory;
 
-      public FakeStoreFactory() {
+      FakeStoreFactory() {
          factory = new FakeSequentialFileFactory();
       }
 
-      public FakeStoreFactory(final SequentialFileFactory factory) {
+      FakeStoreFactory(final SequentialFileFactory factory) {
          this.factory = factory;
       }
 

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/postoffice/impl/WildcardAddressManagerUnitTest.java
----------------------------------------------------------------------
diff --git a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/postoffice/impl/WildcardAddressManagerUnitTest.java b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/postoffice/impl/WildcardAddressManagerUnitTest.java
index 23b1c65..61783ac 100644
--- a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/postoffice/impl/WildcardAddressManagerUnitTest.java
+++ b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/postoffice/impl/WildcardAddressManagerUnitTest.java
@@ -84,11 +84,11 @@ public class WildcardAddressManagerUnitTest extends ActiveMQTestBase {
       final SimpleString address;
       final SimpleString id;
 
-      public BindingFake(String addressParameter, String id) {
+      BindingFake(String addressParameter, String id) {
          this(SimpleString.toSimpleString(addressParameter), SimpleString.toSimpleString(id));
       }
 
-      public BindingFake(SimpleString addressParameter, SimpleString id) {
+      BindingFake(SimpleString addressParameter, SimpleString id) {
          this.address = addressParameter;
          this.id = id;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/3923ae45/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/server/impl/QueueImplTest.java
----------------------------------------------------------------------
diff --git a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/server/impl/QueueImplTest.java b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/server/impl/QueueImplTest.java
index e21d6d9..b98c419 100644
--- a/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/server/impl/QueueImplTest.java
+++ b/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/server/impl/QueueImplTest.java
@@ -1219,10 +1219,10 @@ public class QueueImplTest extends ActiveMQTestBase {
 
       boolean first;
 
-      public AddtoQueueRunner(final boolean first,
-                              final QueueImpl queue,
-                              final MessageReference messageReference,
-                              final CountDownLatch countDownLatch) {
+      AddtoQueueRunner(final boolean first,
+                       final QueueImpl queue,
+                       final MessageReference messageReference,
+                       final CountDownLatch countDownLatch) {
          this.queue = queue;
          this.messageReference = messageReference;
          this.countDownLatch = countDownLatch;