[GitHub] eolivelli commented on a change in pull request #1137: Fix test regression due to change in default ledger manager

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #1137: Fix test regression due to change in default ledger manager
URL: https://github.com/apache/bookkeeper/pull/1137#discussion_r167700970
 
 

 ##########
 File path: bookkeeper-benchmark/src/test/java/org/apache/bookkeeper/benchmark/TestBenchmark.java
 ##########
 @@ -38,6 +39,13 @@ public TestBenchmark() {
         super(5);
     }
 
+    @Before
+    public void setUp() throws Exception {
+        baseConf.setLedgerManagerFactoryClassName("org.apache.bookkeeper.meta.FlatLedgerManagerFactory");
 
 Review comment:
   Why are you using a string and not an explicit reference to the class?
   Having a strong compile time reference will ease refactoring and code analysis

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services