You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/08/25 23:00:50 UTC

[GitHub] [incubator-yunikorn-k8shim] yangwwei opened a new pull request #184: [YUNIKORN-376] Update K8s dependency to 1.16 in k8shim repo

yangwwei opened a new pull request #184:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/184


   This is a refined PR after #181 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #184: [YUNIKORN-376] Update K8s dependency to 1.16 in k8shim repo

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #184:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/184#issuecomment-680324113


   # [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=h1) Report
   > Merging [#184](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/ac345b38432b416aede47e3d51d5e120011c56fd?el=desc) will **increase** coverage by `0.13%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/graphs/tree.svg?width=650&height=150&src=pr&token=LZImIuvleR)](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #184      +/-   ##
   ==========================================
   + Coverage   57.80%   57.93%   +0.13%     
   ==========================================
     Files          33       33              
     Lines        3320     3295      -25     
   ==========================================
   - Hits         1919     1909      -10     
   + Misses       1324     1314      -10     
   + Partials       77       72       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/plugin/predicates/predictor.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9wcmVkaWNhdGVzL3ByZWRpY3Rvci5nbw==) | `85.36% <ø> (+7.66%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=footer). Last update [ac345b3...afe078b](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-yunikorn-k8shim] wilfred-s closed pull request #184: [YUNIKORN-376] Update K8s dependency to 1.16 in k8shim repo

Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #184:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/184


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #184: [YUNIKORN-376] Update K8s dependency to 1.16 in k8shim repo

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #184:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/184#issuecomment-680324113


   # [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=h1) Report
   > Merging [#184](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/7084ff6baa984f3c9b2c9552859e2c3e98c104b6?el=desc) will **increase** coverage by `0.24%`.
   > The diff coverage is `60.89%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/graphs/tree.svg?width=650&height=150&src=pr&token=LZImIuvleR)](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #184      +/-   ##
   ==========================================
   + Coverage   57.68%   57.93%   +0.24%     
   ==========================================
     Files          32       33       +1     
     Lines        3160     3295     +135     
   ==========================================
   + Hits         1823     1909      +86     
   - Misses       1268     1314      +46     
   - Partials       69       72       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/cache/application\_events.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uX2V2ZW50cy5nbw==) | `49.05% <0.00%> (-15.95%)` | :arrow_down: |
   | [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `32.25% <0.00%> (ø)` | |
   | [pkg/common/events/recorder.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9ldmVudHMvcmVjb3JkZXIuZ28=) | `36.36% <0.00%> (ø)` | |
   | [pkg/common/si\_helper.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9zaV9oZWxwZXIuZ28=) | `60.39% <0.00%> (ø)` | |
   | [pkg/common/utils/utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy91dGlscy5nbw==) | `16.16% <0.00%> (ø)` | |
   | [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `84.34% <0.00%> (-3.27%)` | :arrow_down: |
   | [pkg/plugin/predicates/predictor.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9wcmVkaWNhdGVzL3ByZWRpY3Rvci5nbw==) | `85.36% <ø> (+7.66%)` | :arrow_up: |
   | [pkg/shim/main.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL3NoaW0vbWFpbi5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `78.47% <33.33%> (-0.72%)` | :arrow_down: |
   | [pkg/appmgmt/appmgmt.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL2FwcG1nbXQvYXBwbWdtdC5nbw==) | `30.90% <35.71%> (+2.33%)` | :arrow_up: |
   | ... and [10 more](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=footer). Last update [ac345b3...b35a9a6](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #184: [YUNIKORN-376] Update K8s dependency to 1.16 in k8shim repo

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #184:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/184#issuecomment-680324113


   # [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=h1) Report
   > Merging [#184](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/7084ff6baa984f3c9b2c9552859e2c3e98c104b6?el=desc) will **increase** coverage by `0.24%`.
   > The diff coverage is `60.89%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/graphs/tree.svg?width=650&height=150&src=pr&token=LZImIuvleR)](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #184      +/-   ##
   ==========================================
   + Coverage   57.68%   57.93%   +0.24%     
   ==========================================
     Files          32       33       +1     
     Lines        3160     3295     +135     
   ==========================================
   + Hits         1823     1909      +86     
   - Misses       1268     1314      +46     
   - Partials       69       72       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/cache/application\_events.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uX2V2ZW50cy5nbw==) | `49.05% <0.00%> (-15.95%)` | :arrow_down: |
   | [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `32.25% <0.00%> (ø)` | |
   | [pkg/common/events/recorder.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9ldmVudHMvcmVjb3JkZXIuZ28=) | `36.36% <0.00%> (ø)` | |
   | [pkg/common/si\_helper.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9zaV9oZWxwZXIuZ28=) | `60.39% <0.00%> (ø)` | |
   | [pkg/common/utils/utils.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi91dGlscy91dGlscy5nbw==) | `16.16% <0.00%> (ø)` | |
   | [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `84.34% <0.00%> (-3.27%)` | :arrow_down: |
   | [pkg/plugin/predicates/predictor.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9wcmVkaWNhdGVzL3ByZWRpY3Rvci5nbw==) | `85.36% <ø> (+7.66%)` | :arrow_up: |
   | [pkg/shim/main.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL3NoaW0vbWFpbi5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `78.47% <33.33%> (-0.72%)` | :arrow_down: |
   | [pkg/appmgmt/appmgmt.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL2FwcG1nbXQvYXBwbWdtdC5nbw==) | `30.90% <35.71%> (+2.33%)` | :arrow_up: |
   | ... and [10 more](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=footer). Last update [ac345b3...b35a9a6](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #184: [YUNIKORN-376] Update K8s dependency to 1.16 in k8shim repo

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #184:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/184#issuecomment-680324113


   # [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=h1) Report
   > Merging [#184](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/ac345b38432b416aede47e3d51d5e120011c56fd?el=desc) will **increase** coverage by `0.13%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/graphs/tree.svg?width=650&height=150&src=pr&token=LZImIuvleR)](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #184      +/-   ##
   ==========================================
   + Coverage   57.80%   57.93%   +0.13%     
   ==========================================
     Files          33       33              
     Lines        3320     3295      -25     
   ==========================================
   - Hits         1919     1909      -10     
   + Misses       1324     1314      -10     
   + Partials       77       72       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/plugin/predicates/predictor.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9wcmVkaWNhdGVzL3ByZWRpY3Rvci5nbw==) | `85.36% <ø> (+7.66%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=footer). Last update [ac345b3...7a2301f](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #184: [YUNIKORN-376] Update K8s dependency to 1.16 in k8shim repo

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #184:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/184#issuecomment-680324113


   # [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=h1) Report
   > Merging [#184](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/ac345b38432b416aede47e3d51d5e120011c56fd?el=desc) will **increase** coverage by `0.13%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/graphs/tree.svg?width=650&height=150&src=pr&token=LZImIuvleR)](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #184      +/-   ##
   ==========================================
   + Coverage   57.80%   57.93%   +0.13%     
   ==========================================
     Files          33       33              
     Lines        3320     3295      -25     
   ==========================================
   - Hits         1919     1909      -10     
   + Misses       1324     1314      -10     
   + Partials       77       72       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/plugin/predicates/predictor.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9wcmVkaWNhdGVzL3ByZWRpY3Rvci5nbw==) | `85.36% <ø> (+7.66%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=footer). Last update [ac345b3...9e6f866](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #184: [YUNIKORN-376] Update K8s dependency to 1.16 in k8shim repo

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #184:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/184#issuecomment-680324113


   # [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=h1) Report
   > Merging [#184](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/ac345b38432b416aede47e3d51d5e120011c56fd?el=desc) will **increase** coverage by `0.13%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/graphs/tree.svg?width=650&height=150&src=pr&token=LZImIuvleR)](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #184      +/-   ##
   ==========================================
   + Coverage   57.80%   57.93%   +0.13%     
   ==========================================
     Files          33       33              
     Lines        3320     3295      -25     
   ==========================================
   - Hits         1919     1909      -10     
   + Misses       1324     1314      -10     
   + Partials       77       72       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/plugin/predicates/predictor.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9wcmVkaWNhdGVzL3ByZWRpY3Rvci5nbw==) | `85.36% <ø> (+7.66%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=footer). Last update [ac345b3...9e6f866](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #184: [YUNIKORN-376] Update K8s dependency to 1.16 in k8shim repo

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #184:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/184#issuecomment-680324113


   # [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=h1) Report
   > Merging [#184](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/ac345b38432b416aede47e3d51d5e120011c56fd?el=desc) will **increase** coverage by `0.13%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/graphs/tree.svg?width=650&height=150&src=pr&token=LZImIuvleR)](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #184      +/-   ##
   ==========================================
   + Coverage   57.80%   57.93%   +0.13%     
   ==========================================
     Files          33       33              
     Lines        3320     3295      -25     
   ==========================================
   - Hits         1919     1909      -10     
   + Misses       1324     1314      -10     
   + Partials       77       72       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/plugin/predicates/predictor.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9wcmVkaWNhdGVzL3ByZWRpY3Rvci5nbw==) | `85.36% <ø> (+7.66%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=footer). Last update [ac345b3...138b78e](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/184?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org