You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by iilyak <gi...@git.apache.org> on 2016/08/19 23:31:20 UTC
[GitHub] couchdb-mem3 pull request #25: Update handle_config_terminate API
GitHub user iilyak opened a pull request:
https://github.com/apache/couchdb-mem3/pull/25
Update handle_config_terminate API
Update handle_config_terminate API to match changes in apache/couchdb-config#11
COUCHDB-3102
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-mem3 3102-fix-config_subscription
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-mem3/pull/25.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #25
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-mem3 pull request #25: Update handle_config_terminate API
Posted by iilyak <gi...@git.apache.org>.
Github user iilyak commented on a diff in the pull request:
https://github.com/apache/couchdb-mem3/pull/25#discussion_r75567400
--- Diff: src/mem3_sync_event_listener.erl ---
@@ -59,7 +60,7 @@ start_link() ->
couch_event_listener:start_link(?MODULE, [], [all_dbs]).
init(_) ->
- config:listen_for_changes(?MODULE, undefined),
+ {ok, _} = config:listen_for_changes(?MODULE, undefined),
--- End diff --
This is still broken. Since it is not registered process.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-mem3 pull request #25: Update handle_config_terminate API
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-mem3/pull/25
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-mem3 issue #25: Update handle_config_terminate API
Posted by davisp <gi...@git.apache.org>.
Github user davisp commented on the issue:
https://github.com/apache/couchdb-mem3/pull/25
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-mem3 pull request #25: Update handle_config_terminate API
Posted by iilyak <gi...@git.apache.org>.
Github user iilyak commented on a diff in the pull request:
https://github.com/apache/couchdb-mem3/pull/25#discussion_r75760326
--- Diff: src/mem3_sync_event_listener.erl ---
@@ -59,7 +60,7 @@ start_link() ->
couch_event_listener:start_link(?MODULE, [], [all_dbs]).
init(_) ->
- config:listen_for_changes(?MODULE, undefined),
+ {ok, _} = config:listen_for_changes(?MODULE, undefined),
--- End diff --
Should be fixed now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---