You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by rm...@apache.org on 2015/06/17 02:04:05 UTC
[1/2] tomee git commit: ensure to remove the task with cancel call
Repository: tomee
Updated Branches:
refs/heads/master f9959484a -> 4cf313cf4
ensure to remove the task with cancel call
Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/ac0c779d
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/ac0c779d
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/ac0c779d
Branch: refs/heads/master
Commit: ac0c779d1cacd16b7ec43cd83a20b16013407019
Parents: f995948
Author: Romain Manni-Bucau <rm...@apache.org>
Authored: Wed Jun 17 01:57:22 2015 +0200
Committer: Romain Manni-Bucau <rm...@apache.org>
Committed: Wed Jun 17 01:57:22 2015 +0200
----------------------------------------------------------------------
.../openejb/core/stateless/StatelessInstanceManager.java | 4 ++++
.../src/main/java/org/apache/openejb/util/Pool.java | 6 +++++-
2 files changed, 9 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tomee/blob/ac0c779d/container/openejb-core/src/main/java/org/apache/openejb/core/stateless/StatelessInstanceManager.java
----------------------------------------------------------------------
diff --git a/container/openejb-core/src/main/java/org/apache/openejb/core/stateless/StatelessInstanceManager.java b/container/openejb-core/src/main/java/org/apache/openejb/core/stateless/StatelessInstanceManager.java
index 82cb094..aa6617c 100644
--- a/container/openejb-core/src/main/java/org/apache/openejb/core/stateless/StatelessInstanceManager.java
+++ b/container/openejb-core/src/main/java/org/apache/openejb/core/stateless/StatelessInstanceManager.java
@@ -65,6 +65,7 @@ import java.util.concurrent.Executors;
import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.RejectedExecutionHandler;
import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.ScheduledThreadPoolExecutor;
import java.util.concurrent.ThreadFactory;
import java.util.concurrent.ThreadPoolExecutor;
import java.util.concurrent.TimeUnit;
@@ -100,6 +101,9 @@ public class StatelessInstanceManager {
this.closeTimeout = closeTimeout;
this.poolBuilder = poolBuilder;
this.scheduledExecutor = ses;
+ if (ScheduledThreadPoolExecutor.class.isInstance(ses)) {
+ ScheduledThreadPoolExecutor.class.cast(ses).setRemoveOnCancelPolicy(true);
+ }
if (accessTimeout.getUnit() == null) {
accessTimeout.setUnit(TimeUnit.MILLISECONDS);
http://git-wip-us.apache.org/repos/asf/tomee/blob/ac0c779d/container/openejb-core/src/main/java/org/apache/openejb/util/Pool.java
----------------------------------------------------------------------
diff --git a/container/openejb-core/src/main/java/org/apache/openejb/util/Pool.java b/container/openejb-core/src/main/java/org/apache/openejb/util/Pool.java
index 73f5bbc..cdb966f 100644
--- a/container/openejb-core/src/main/java/org/apache/openejb/util/Pool.java
+++ b/container/openejb-core/src/main/java/org/apache/openejb/util/Pool.java
@@ -140,7 +140,11 @@ public class Pool<T> {
createdSES = false;
}
}
- if (this.future.compareAndSet(null, scheduledExecutorService.scheduleAtFixedRate(sweeper, 0, this.sweepInterval, MILLISECONDS)) && !createdSES) {
+ final ScheduledFuture<?> scheduledFuture = scheduledExecutorService.scheduleAtFixedRate(sweeper, 0, this.sweepInterval, MILLISECONDS);
+ if (!this.future.compareAndSet(null, scheduledFuture)) {
+ scheduledFuture.cancel(true);
+ }
+ if (!createdSES) {
// we don't want to shutdown it, we'll just stop the task
this.scheduler.set(null);
}
[2/2] tomee git commit: activating cdi for webprofile arquillian
tests to avoid to skip plume distrib
Posted by rm...@apache.org.
activating cdi for webprofile arquillian tests to avoid to skip plume distrib
Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/4cf313cf
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/4cf313cf
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/4cf313cf
Branch: refs/heads/master
Commit: 4cf313cf432f98375735b798a5e9fbec9d7f2035
Parents: ac0c779
Author: Romain Manni-Bucau <rm...@apache.org>
Authored: Wed Jun 17 02:03:25 2015 +0200
Committer: Romain Manni-Bucau <rm...@apache.org>
Committed: Wed Jun 17 02:03:25 2015 +0200
----------------------------------------------------------------------
.../apache/openejb/arquillian/tests/jsf/jpa/JPAInjectionTest.java | 2 ++
.../arquillian/tests/jsf/resource/JSFResourceInjectionTest.java | 2 ++
2 files changed, 4 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tomee/blob/4cf313cf/arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/jsf/jpa/JPAInjectionTest.java
----------------------------------------------------------------------
diff --git a/arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/jsf/jpa/JPAInjectionTest.java b/arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/jsf/jpa/JPAInjectionTest.java
index 179b03a..07b476a 100644
--- a/arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/jsf/jpa/JPAInjectionTest.java
+++ b/arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/jsf/jpa/JPAInjectionTest.java
@@ -24,6 +24,7 @@ import org.jboss.arquillian.junit.Arquillian;
import org.jboss.arquillian.test.api.ArquillianResource;
import org.jboss.shrinkwrap.api.asset.Asset;
import org.jboss.shrinkwrap.api.asset.ClassLoaderAsset;
+import org.jboss.shrinkwrap.api.asset.EmptyAsset;
import org.jboss.shrinkwrap.api.asset.StringAsset;
import org.jboss.shrinkwrap.api.spec.WebArchive;
import org.jboss.shrinkwrap.descriptor.api.Descriptors;
@@ -56,6 +57,7 @@ public class JPAInjectionTest extends JSFs {
Asset persistenceAsset = new StringAsset(persistenceDescriptor.exportAsString());
return base("jsf-jpa-test.war").addAsWebInfResource(persistenceAsset, "persistence.xml")
.addClasses(DummyManagedBean.class)
+ .addAsWebInfResource(EmptyAsset.INSTANCE, "beans.xml")
.addAsWebResource(new ClassLoaderAsset(
JPAInjectionTest.class.getPackage().getName().replace('.', '/').concat("/").concat("dummy.xhtml")), "dummy.xhtml");
http://git-wip-us.apache.org/repos/asf/tomee/blob/4cf313cf/arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/jsf/resource/JSFResourceInjectionTest.java
----------------------------------------------------------------------
diff --git a/arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/jsf/resource/JSFResourceInjectionTest.java b/arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/jsf/resource/JSFResourceInjectionTest.java
index 6ae63d6..009cfce 100644
--- a/arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/jsf/resource/JSFResourceInjectionTest.java
+++ b/arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/jsf/resource/JSFResourceInjectionTest.java
@@ -22,6 +22,7 @@ import org.jboss.arquillian.container.test.api.Deployment;
import org.jboss.arquillian.junit.Arquillian;
import org.jboss.arquillian.test.api.ArquillianResource;
import org.jboss.shrinkwrap.api.asset.ClassLoaderAsset;
+import org.jboss.shrinkwrap.api.asset.EmptyAsset;
import org.jboss.shrinkwrap.api.spec.WebArchive;
import org.junit.Test;
import org.junit.runner.RunWith;
@@ -41,6 +42,7 @@ public class JSFResourceInjectionTest extends JSFs {
public static WebArchive getArchive() {
return base("jsf-resource-injection-test.war")
.addClass(ResourceManagedBean.class)
+ .addAsWebInfResource(EmptyAsset.INSTANCE, "beans.xml")
.addAsWebResource(new ClassLoaderAsset(
JSFResourceInjectionTest.class.getPackage()
.getName().replace('.', '/').concat("/resource.xhtml")), "resource.xhtml");