You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Nixon Rodrigues <ni...@freestoneinfotech.com> on 2017/07/25 11:30:29 UTC
Review Request 61103: ATLAS-1985 :- Fix URLEncoding while redirecting
to Active instance in HA.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61103/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Kelkar, Madhan Neethiraj, and Sarath Subramanian.
Repository: atlas
Description
-------
This patch provide fix for url-encoding in Activeserver Filter where url was encoded wrongly with HtmlQuoting.quoteHtmlChars method which is primarily meant for htmltext encoding.
Instead of using HtmlQuoting.quoteHtmlChars method used URLEncode.encode method to encode the URL.
Diffs
-----
webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 29d829f
webapp/src/test/java/org/apache/atlas/web/filters/ActiveServerFilterTest.java 3396072
Diff: https://reviews.apache.org/r/61103/diff/1/
Testing
-------
Tested api redirected from passive to active
eg /api/atlas/discovery/search/fulltext?limit=100&query=hive_table API is redirection to active with
/api/atlas/discovery/search/fulltext?limit%3D100%26query%3Dhive_table where querystring is encoded.
Existing UT and IT's passing.
Added new UT in ActiveServerFilterTest
Thanks,
Nixon Rodrigues
Re: Review Request 61103: ATLAS-1985 :- Fix URLEncoding while
redirecting to Active instance in HA.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61103/#review181342
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On July 25, 2017, 11:30 a.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61103/
> -----------------------------------------------------------
>
> (Updated July 25, 2017, 11:30 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Kelkar, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch provide fix for url-encoding in Activeserver Filter where url was encoded wrongly with HtmlQuoting.quoteHtmlChars method which is primarily meant for htmltext encoding.
>
> Instead of using HtmlQuoting.quoteHtmlChars method used URLEncode.encode method to encode the URL.
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 29d829f
> webapp/src/test/java/org/apache/atlas/web/filters/ActiveServerFilterTest.java 3396072
>
>
> Diff: https://reviews.apache.org/r/61103/diff/1/
>
>
> Testing
> -------
>
> Tested api redirected from passive to active
> eg /api/atlas/discovery/search/fulltext?limit=100&query=hive_table API is redirection to active with
> /api/atlas/discovery/search/fulltext?limit%3D100%26query%3Dhive_table where querystring is encoded.
>
> Existing UT and IT's passing.
> Added new UT in ActiveServerFilterTest
>
>
> Thanks,
>
> Nixon Rodrigues
>
>
Re: Review Request 61103: ATLAS-1985 :- Fix URLEncoding while
redirecting to Active instance in HA.
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61103/#review181353
-----------------------------------------------------------
Ship it!
Ship It!
- Ashutosh Mestry
On July 25, 2017, 11:30 a.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61103/
> -----------------------------------------------------------
>
> (Updated July 25, 2017, 11:30 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Kelkar, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch provide fix for url-encoding in Activeserver Filter where url was encoded wrongly with HtmlQuoting.quoteHtmlChars method which is primarily meant for htmltext encoding.
>
> Instead of using HtmlQuoting.quoteHtmlChars method used URLEncode.encode method to encode the URL.
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 29d829f
> webapp/src/test/java/org/apache/atlas/web/filters/ActiveServerFilterTest.java 3396072
>
>
> Diff: https://reviews.apache.org/r/61103/diff/1/
>
>
> Testing
> -------
>
> Tested api redirected from passive to active
> eg /api/atlas/discovery/search/fulltext?limit=100&query=hive_table API is redirection to active with
> /api/atlas/discovery/search/fulltext?limit%3D100%26query%3Dhive_table where querystring is encoded.
>
> Existing UT and IT's passing.
> Added new UT in ActiveServerFilterTest
>
>
> Thanks,
>
> Nixon Rodrigues
>
>