You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Fred Cooke (JIRA)" <ji...@codehaus.org> on 2013/01/01 01:32:13 UTC
[jira] (MRELEASE-816) Various issues with scmCommentPrefix value
Fred Cooke created MRELEASE-816:
-----------------------------------
Summary: Various issues with scmCommentPrefix value
Key: MRELEASE-816
URL: https://jira.codehaus.org/browse/MRELEASE-816
Project: Maven 2.x Release Plugin
Issue Type: Bug
Components: prepare
Affects Versions: 2.3.2
Environment: Debian Linux OpenJDK 7 mvn 3.0.4
Reporter: Fred Cooke
Priority: Minor
When the {{ <scmCommentPrefix> }} property is specified the trailing space is ignored/trimmed for one of the steps and used for the other. When not specified the [maven-release-plugin] has a trailing space for both commit messages. For example:
Releasing sticky-deployer-embedded at 0.8-SNAPSHOTprepare for next development iteration
Releasing sticky-deployer-embedded at 0.8-SNAPSHOT copy for tag sticky-deployer-embedded-0.8
Versus:
[maven-release-plugin] prepare for next development iteration
[maven-release-plugin] prepare release 0.1
Additionally, the version substituted into ${project.version} in this config is the SNAPSHOT version from before the release. The tagNameFormat value uses the @{project.version} variant to get around this, however if you try to use that in the scmCommentPrefix field you get an error.
Ideally I'd like to set it up like this and have the trailing space respected for both commits, and the release version used:
<scmCommentPrefix>Releasing ${project.artifactId} version @{project.version}: </scmCommentPrefix>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-816) Various issues with scmCommentPrefix value
Posted by "Fred Cooke (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fred Cooke reopened MRELEASE-816:
---------------------------------
See previous comment re consistency. There are at least two possible fixes:
1) Remove space from first commit
2) Add space to second commit
Clearly the latter is preferred as it works around the inability to add space yourself and is something that pretty much everyone would always want.
> Various issues with scmCommentPrefix value
> ------------------------------------------
>
> Key: MRELEASE-816
> URL: https://jira.codehaus.org/browse/MRELEASE-816
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: prepare
> Affects Versions: 2.3.2
> Environment: Debian Linux OpenJDK 7 mvn 3.0.4
> Reporter: Fred Cooke
> Assignee: Robert Scholte
> Priority: Minor
>
> When the {{ <scmCommentPrefix> }} property is specified the trailing space is ignored/trimmed for one of the steps and used for the other. When not specified the [maven-release-plugin] has a trailing space for both commit messages. For example:
> Releasing sticky-deployer-embedded at 0.8-SNAPSHOTprepare for next development iteration
> Releasing sticky-deployer-embedded at 0.8-SNAPSHOT copy for tag sticky-deployer-embedded-0.8
> Versus:
> [maven-release-plugin] prepare for next development iteration
> [maven-release-plugin] prepare release 0.1
> Additionally, the version substituted into ${project.version} in this config is the SNAPSHOT version from before the release. The tagNameFormat value uses the @{project.version} variant to get around this, however if you try to use that in the scmCommentPrefix field you get an error.
> Ideally I'd like to set it up like this and have the trailing space respected for both commits, and the release version used:
> <scmCommentPrefix>Releasing ${project.artifactId} version @{project.version}: </scmCommentPrefix>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-816) Various issues with scmCommentPrefix value
Posted by "Fred Cooke (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=316433#comment-316433 ]
Fred Cooke commented on MRELEASE-816:
-------------------------------------
In the mean time, how about inserting a space, just as you clearly do for the standard [maven-release-plugin] value. If that value includes a space, remove it and insert it by default elsewhere. Thanks for the link to 696, I added a watch to it.
> Various issues with scmCommentPrefix value
> ------------------------------------------
>
> Key: MRELEASE-816
> URL: https://jira.codehaus.org/browse/MRELEASE-816
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: prepare
> Affects Versions: 2.3.2
> Environment: Debian Linux OpenJDK 7 mvn 3.0.4
> Reporter: Fred Cooke
> Assignee: Robert Scholte
> Priority: Minor
>
> When the {{ <scmCommentPrefix> }} property is specified the trailing space is ignored/trimmed for one of the steps and used for the other. When not specified the [maven-release-plugin] has a trailing space for both commit messages. For example:
> Releasing sticky-deployer-embedded at 0.8-SNAPSHOTprepare for next development iteration
> Releasing sticky-deployer-embedded at 0.8-SNAPSHOT copy for tag sticky-deployer-embedded-0.8
> Versus:
> [maven-release-plugin] prepare for next development iteration
> [maven-release-plugin] prepare release 0.1
> Additionally, the version substituted into ${project.version} in this config is the SNAPSHOT version from before the release. The tagNameFormat value uses the @{project.version} variant to get around this, however if you try to use that in the scmCommentPrefix field you get an error.
> Ideally I'd like to set it up like this and have the trailing space respected for both commits, and the release version used:
> <scmCommentPrefix>Releasing ${project.artifactId} version @{project.version}: </scmCommentPrefix>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-816) Various issues with scmCommentPrefix value
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Scholte closed MRELEASE-816.
-----------------------------------
Resolution: Won't Fix
Assignee: Robert Scholte
You're referring to 2 issues: one is a Maven Core issue, the other is a duplicate.
The configuration-fields are always trimmed by Plexus (the container of Maven), that's out of the hands of the plugin. But there's hope: PLXUTILS-154 adds the ability to preserve the space.
The other is a duplicate of MRELEASE-696.
> Various issues with scmCommentPrefix value
> ------------------------------------------
>
> Key: MRELEASE-816
> URL: https://jira.codehaus.org/browse/MRELEASE-816
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: prepare
> Affects Versions: 2.3.2
> Environment: Debian Linux OpenJDK 7 mvn 3.0.4
> Reporter: Fred Cooke
> Assignee: Robert Scholte
> Priority: Minor
>
> When the {{ <scmCommentPrefix> }} property is specified the trailing space is ignored/trimmed for one of the steps and used for the other. When not specified the [maven-release-plugin] has a trailing space for both commit messages. For example:
> Releasing sticky-deployer-embedded at 0.8-SNAPSHOTprepare for next development iteration
> Releasing sticky-deployer-embedded at 0.8-SNAPSHOT copy for tag sticky-deployer-embedded-0.8
> Versus:
> [maven-release-plugin] prepare for next development iteration
> [maven-release-plugin] prepare release 0.1
> Additionally, the version substituted into ${project.version} in this config is the SNAPSHOT version from before the release. The tagNameFormat value uses the @{project.version} variant to get around this, however if you try to use that in the scmCommentPrefix field you get an error.
> Ideally I'd like to set it up like this and have the trailing space respected for both commits, and the release version used:
> <scmCommentPrefix>Releasing ${project.artifactId} version @{project.version}: </scmCommentPrefix>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-816) Various issues with scmCommentPrefix value
Posted by "Fred Cooke (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=316434#comment-316434 ]
Fred Cooke commented on MRELEASE-816:
-------------------------------------
And in any case, a space IS inserted for one operation, and not the other, so they should be consistent.
> Various issues with scmCommentPrefix value
> ------------------------------------------
>
> Key: MRELEASE-816
> URL: https://jira.codehaus.org/browse/MRELEASE-816
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: prepare
> Affects Versions: 2.3.2
> Environment: Debian Linux OpenJDK 7 mvn 3.0.4
> Reporter: Fred Cooke
> Assignee: Robert Scholte
> Priority: Minor
>
> When the {{ <scmCommentPrefix> }} property is specified the trailing space is ignored/trimmed for one of the steps and used for the other. When not specified the [maven-release-plugin] has a trailing space for both commit messages. For example:
> Releasing sticky-deployer-embedded at 0.8-SNAPSHOTprepare for next development iteration
> Releasing sticky-deployer-embedded at 0.8-SNAPSHOT copy for tag sticky-deployer-embedded-0.8
> Versus:
> [maven-release-plugin] prepare for next development iteration
> [maven-release-plugin] prepare release 0.1
> Additionally, the version substituted into ${project.version} in this config is the SNAPSHOT version from before the release. The tagNameFormat value uses the @{project.version} variant to get around this, however if you try to use that in the scmCommentPrefix field you get an error.
> Ideally I'd like to set it up like this and have the trailing space respected for both commits, and the release version used:
> <scmCommentPrefix>Releasing ${project.artifactId} version @{project.version}: </scmCommentPrefix>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira