You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/12/24 03:58:26 UTC

[GitHub] [orc] belugabehr commented on a change in pull request #977: ORC-1064: Rework Attribute Map in TypeDescription class

belugabehr commented on a change in pull request #977:
URL: https://github.com/apache/orc/pull/977#discussion_r774861777



##########
File path: java/core/src/java/org/apache/orc/TypeDescription.java
##########
@@ -372,9 +372,7 @@ public TypeDescription clone() {
         result.children.add(clone);
       }
     }
-    for (Map.Entry<String,String> pair: attributes.entrySet()) {
-      result.attributes.put(pair.getKey(), pair.getValue());
-    }
+    result.attributes.putAll(attributes);

Review comment:
       No need to iterate like this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org