You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/12/12 02:10:34 UTC
[kudu-CR] [master-test] fix race in ConcurrentGetTableSchemaTest
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16865
Change subject: [master-test] fix race in ConcurrentGetTableSchemaTest
......................................................................
[master-test] fix race in ConcurrentGetTableSchemaTest
This patch adds explicit joining for the worker threads before
trying to accumulate per-thread counters. Prior to this patch,
a rare race was reported in TSAN builds.
Change-Id: I5bc620c61320587fea92706c94b113a3bbd3e91e
---
M src/kudu/master/master-test.cc
1 file changed, 3 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/16865/1
--
To view, visit http://gerrit.cloudera.org:8080/16865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5bc620c61320587fea92706c94b113a3bbd3e91e
Gerrit-Change-Number: 16865
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [master-test] fix race in ConcurrentGetTableSchemaTest
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16865 )
Change subject: [master-test] fix race in ConcurrentGetTableSchemaTest
......................................................................
[master-test] fix race in ConcurrentGetTableSchemaTest
This patch adds explicit joining for the worker threads before
trying to accumulate per-thread counters. Prior to this patch,
a rare race was reported in TSAN builds.
Change-Id: I5bc620c61320587fea92706c94b113a3bbd3e91e
Reviewed-on: http://gerrit.cloudera.org:8080/16865
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/master/master-test.cc
1 file changed, 3 insertions(+), 5 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5bc620c61320587fea92706c94b113a3bbd3e91e
Gerrit-Change-Number: 16865
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [master-test] fix race in ConcurrentGetTableSchemaTest
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16865 )
Change subject: [master-test] fix race in ConcurrentGetTableSchemaTest
......................................................................
Patch Set 1: Code-Review+2
Nice find!
--
To view, visit http://gerrit.cloudera.org:8080/16865
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bc620c61320587fea92706c94b113a3bbd3e91e
Gerrit-Change-Number: 16865
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 12 Dec 2020 02:16:59 +0000
Gerrit-HasComments: No