You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/29 06:57:47 UTC
[GitHub] [airflow] yyhecust opened a new pull request #17302: fix backfill can not backfill at time 00:00 if set default_timezone=Asia/Shanghai
yyhecust opened a new pull request #17302:
URL: https://github.com/apache/airflow/pull/17302
In case of existing issue, reference it using one of the following:
related: #16961
in backfill function, there are two methods, which are `self._get_dag_run(next_run_date, dag, session=session)` and `self._task_instances_for_dag_run(dag_run, session=session)` in backfill_job.py. In `_get_dag_run` method it use `runs = DagRun.find(dag_id=dag.dag_id, execution_date=run_date, session=session)` to find dagrun, but in `_instances_for_dag_run` it use `dagrun.refresh_from_db` to find dagrun, this method to find dagrun is different from `DagRun.find` so it will cause can not find dagrun when execution_date = 00:00 if set default_timezone=Asia/Shanghai, now I make them the same way to find dagrun, it can backfill successfully.
**^ Add meaningful description above**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #17302: fix backfill can not backfill at time 00:00 if set default_timezone=Asia/Shanghai
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #17302:
URL: https://github.com/apache/airflow/pull/17302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17302: fix backfill can not backfill at time 00:00 if set default_timezone=Asia/Shanghai
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17302:
URL: https://github.com/apache/airflow/pull/17302#issuecomment-889123731
Already scheduled #16809 for 2.1.3 milestone. Closing this one as duplicate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #17302: fix backfill can not backfill at time 00:00 if set default_timezone=Asia/Shanghai
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #17302:
URL: https://github.com/apache/airflow/pull/17302#issuecomment-888860312
It seems like #16809 already fixed this. We just need to remember to backport it to 2.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org