You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/09/25 03:00:34 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request, #43083: [SPARK-45298][SQL][TESTS] Remove the workaround for JDK-8228469 in SPARK-31959 test

HyukjinKwon opened a new pull request, #43083:
URL: https://github.com/apache/spark/pull/43083

   ### What changes were proposed in this pull request?
   
   This PR removes the legacy workaround for old JDK added at SPARK-31959
   
   ### Why are the changes needed?
   
   To remove legacy workaround. We dropped JDK 8/11 at SPARK-44112
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Existing unittest/docs added in SPARK-31959
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #43083: [SPARK-45298][SQL][TESTS] Remove the workaround for JDK-8228469 in SPARK-31959 test

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #43083: [SPARK-45298][SQL][TESTS] Remove the workaround for JDK-8228469 in SPARK-31959 test
URL: https://github.com/apache/spark/pull/43083


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #43083: [SPARK-45298][SQL][TESTS] Remove the workaround for JDK-8228469 in SPARK-31959 test

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43083:
URL: https://github.com/apache/spark/pull/43083#issuecomment-1733813371

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on pull request #43083: [SPARK-45298][SQL][TESTS] Remove the workaround for JDK-8228469 in SPARK-31959 test

Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #43083:
URL: https://github.com/apache/spark/pull/43083#issuecomment-1733064416

   @HyukjinKwon Thanks for the ping. I will review this PR soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #43083: [SPARK-45298][SQL][TESTS] Remove the workaround for JDK-8228469 in SPARK-31959 test

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43083:
URL: https://github.com/apache/spark/pull/43083#issuecomment-1732830208

   cc @MaxGekk 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org