[jira] [Comment Edited] (REEF-1134) Wake Codec creation pattern is not consistent

["Andrew Chung (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/REEF-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109833#comment-15109833 ] 

Andrew Chung edited comment on REEF-1134 at 1/21/16 12:52 AM:
--------------------------------------------------------------

I've deprecated the {{ICodecFactory}} interface since:
# Only {{ByteCodec}} uses {{ICodecFactory}}.
# {{ByteCodec}} itself has an injectable {{public}} constructor.
# {{ICodecFactory}} is not actually used anywhere in the codebase.
# {{ICodecFactory}} returns {{object}} instead of either {{ICodec}} or {{ICodec<T>}}.
# REEF Java uses injectable {{public}} constructors.


was (Author: afchung90):
I've deprecated the `ICodecFactory` interface since:
# Only `ByteCodec` uses `ICodecFactory`.
# `ByteCodec` itself has an injectable `public` constructor.
# `ICodecFactory` is not actually used anywhere in the codebase.
# `ICodecFactory` returns `object` instead of either `ICodec` or `ICodec<T>`.
# REEF Java uses injectable `public` constructors.

> Wake Codec creation pattern is not consistent
> ---------------------------------------------
>
>                 Key: REEF-1134
>                 URL: https://issues.apache.org/jira/browse/REEF-1134
>             Project: REEF
>          Issue Type: Bug
>          Components: Wake.NET
>            Reporter: Andrew Chung
>            Assignee: Andrew Chung
>
> Currently, there are a few ways to instantiate Wake Codecs, but there is no consistent pattern. Codecs should either all be created via injection or all be created via factories, but not both ways.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)