You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by eribeiro <gi...@git.apache.org> on 2017/04/27 00:20:57 UTC
[GitHub] zookeeper pull request #241: ZOOKEEPER-2662: Export a metric for txn log syn...
GitHub user eribeiro opened a pull request:
https://github.com/apache/zookeeper/pull/241
ZOOKEEPER-2662: Export a metric for txn log sync times
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eribeiro/zookeeper ZOOKEEPER-2662
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/241.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #241
----
commit 9349c6192a5832def17a35bb6f4769c6aa917a54
Author: Edward Ribeiro <ed...@gmail.com>
Date: 2017-04-27T00:21:18Z
ZOOKEEPER-2662: Export a metric for txn log sync times
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #241: ZOOKEEPER-2662: Export a metric for txn log syn...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/241
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #241: ZOOKEEPER-2662: Export a metric for txn log syn...
Posted by eribeiro <gi...@git.apache.org>.
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/241#discussion_r113824039
--- Diff: src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java ---
@@ -113,6 +116,26 @@ public void testAutoCreateDb() throws IOException {
attemptAutoCreateDb(dataDir, snapDir, sessions, priorAutocreateDbValue, "false", 0L);
}
+ @Test
+ public void testGetTxnLogSyncElapsedTime() throws IOException {
--- End diff --
Done. It looks like this one, so any suggestion to remove duplicate or improve it is welcome.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #241: ZOOKEEPER-2662: Export a metric for txn log syn...
Posted by eribeiro <gi...@git.apache.org>.
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/241#discussion_r113777776
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServerMXBean.java ---
@@ -125,4 +125,6 @@
* @return secure client address
*/
public String getSecureClientAddress();
+
--- End diff --
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #241: ZOOKEEPER-2662: Export a metric for txn log sync times
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/241
lgtm, merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #241: ZOOKEEPER-2662: Export a metric for txn log syn...
Posted by eribeiro <gi...@git.apache.org>.
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/241#discussion_r113821610
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServerBean.java ---
@@ -162,4 +162,12 @@ public String getSecureClientAddress() {
}
return "";
}
+
+ /**
+ * Returns the elapsed sync of time of transaction log in milliseconds.
+ */
--- End diff --
done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #241: ZOOKEEPER-2662: Export a metric for txn log syn...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/241#discussion_r113775960
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServerMXBean.java ---
@@ -125,4 +125,6 @@
* @return secure client address
*/
public String getSecureClientAddress();
+
--- End diff --
Missing interface comment here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #241: ZOOKEEPER-2662: Export a metric for txn log syn...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/241#discussion_r113776378
--- Diff: src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java ---
@@ -113,6 +116,26 @@ public void testAutoCreateDb() throws IOException {
attemptAutoCreateDb(dataDir, snapDir, sessions, priorAutocreateDbValue, "false", 0L);
}
+ @Test
+ public void testGetTxnLogSyncElapsedTime() throws IOException {
--- End diff --
This tests the sync time, but not the bean. It is a good test case to have, but it would be also good to add server bean test for the methods added in this patch (see ZooKeeperServerBeanTest).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #241: ZOOKEEPER-2662: Export a metric for txn log syn...
Posted by eribeiro <gi...@git.apache.org>.
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/241#discussion_r113777785
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServerMXBean.java ---
@@ -125,4 +125,6 @@
* @return secure client address
*/
public String getSecureClientAddress();
+
--- End diff --
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #241: ZOOKEEPER-2662: Export a metric for txn log syn...
Posted by eribeiro <gi...@git.apache.org>.
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/241#discussion_r113821590
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServerMXBean.java ---
@@ -125,4 +125,6 @@
* @return secure client address
*/
public String getSecureClientAddress();
+
--- End diff --
done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #241: ZOOKEEPER-2662: Export a metric for txn log syn...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/241#discussion_r113776089
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServerBean.java ---
@@ -162,4 +162,12 @@ public String getSecureClientAddress() {
}
return "";
}
+
+ /**
+ * Returns the elapsed sync of time of transaction log in milliseconds.
+ */
--- End diff --
This comment can be moved to interface.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---