You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by ke...@apache.org on 2007/01/31 22:22:33 UTC

svn commit: r502004 - /geronimo/server/trunk/assemblies/geronimo-boilerplate-jee5/pom.xml

Author: kevan
Date: Wed Jan 31 13:22:32 2007
New Revision: 502004

URL: http://svn.apache.org/viewvc?view=rev&rev=502004
Log:
GERONIMO-2788 Don't include yoko jars until we have more corba support

Modified:
    geronimo/server/trunk/assemblies/geronimo-boilerplate-jee5/pom.xml

Modified: geronimo/server/trunk/assemblies/geronimo-boilerplate-jee5/pom.xml
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/assemblies/geronimo-boilerplate-jee5/pom.xml?view=diff&rev=502004&r1=502003&r2=502004
==============================================================================
--- geronimo/server/trunk/assemblies/geronimo-boilerplate-jee5/pom.xml (original)
+++ geronimo/server/trunk/assemblies/geronimo-boilerplate-jee5/pom.xml Wed Jan 31 13:22:32 2007
@@ -133,26 +133,30 @@
                         </configuration>
                     </execution>
                     
-                    <execution>
-                        <id>install-lib-endorsed</id>
-                        <phase>compile</phase>
-                        <goals>
-                            <goal>copy</goal>
-                        </goals>
-                        <configuration>
-                            <artifactItems>
-                                <artifactItem>
-                                    <groupId>org.apache.yoko</groupId>
-                                    <artifactId>yoko-spec-corba</artifactId>
-                                </artifactItem>
-                                <artifactItem>
-                                    <groupId>org.apache.yoko</groupId>
-                                    <artifactId>yoko-rmi-spec</artifactId>
-                                </artifactItem>
-                            </artifactItems>
-                            <outputDirectory>${project.build.directory}/classes/lib/endorsed</outputDirectory>
-                        </configuration>
-                    </execution>
+<!--                     Don't include yoko jars in lib/endorsed. This is a temporary measure to avoid -->
+<!--                     PortableRemoteObject constructor errors. Yoko jars will need to be reinstated -->
+<!--                     when we have corba support -->
+
+<!--                     <execution> -->
+<!--                         <id>install-lib-endorsed</id> -->
+<!--                         <phase>compile</phase> -->
+<!--                         <goals> -->
+<!--                             <goal>copy</goal> -->
+<!--                         </goals> -->
+<!--                         <configuration> -->
+<!--                             <artifactItems> -->
+<!--                                 <artifactItem> -->
+<!--                                     <groupId>org.apache.yoko</groupId> -->
+<!--                                     <artifactId>yoko-spec-corba</artifactId> -->
+<!--                                 </artifactItem> -->
+<!--                                 <artifactItem> -->
+<!--                                     <groupId>org.apache.yoko</groupId> -->
+<!--                                     <artifactId>yoko-rmi-spec</artifactId> -->
+<!--                                 </artifactItem> -->
+<!--                             </artifactItems> -->
+<!--                             <outputDirectory>${project.build.directory}/classes/lib/endorsed</outputDirectory> -->
+<!--                         </configuration> -->
+<!--                     </execution> -->
                     
                     <execution>
                         <id>install-lib</id>



Re: svn commit: r502004 - /geronimo/server/trunk/assemblies/geronimo-boilerplate-jee5/pom.xml

Posted by Jason Dillon <ja...@planet57.com>.
Um... would it be possible to *not* use this comment style in the  
future?

I know that IDEA makes this nice any easy to comment and uncomment  
like this, but if you don't use IDEA then its a PITA to remove these  
comments. I think its also kinda ugly looking, but thats just me... :-(

--jason


On Jan 31, 2007, at 1:22 PM, kevan@apache.org wrote:

> Author: kevan
> Date: Wed Jan 31 13:22:32 2007
> New Revision: 502004
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=502004
> Log:
> GERONIMO-2788 Don't include yoko jars until we have more corba support
>
> Modified:
>     geronimo/server/trunk/assemblies/geronimo-boilerplate-jee5/pom.xml
>
> Modified: geronimo/server/trunk/assemblies/geronimo-boilerplate- 
> jee5/pom.xml
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/assemblies/ 
> geronimo-boilerplate-jee5/pom.xml? 
> view=diff&rev=502004&r1=502003&r2=502004
> ====================================================================== 
> ========
> --- geronimo/server/trunk/assemblies/geronimo-boilerplate-jee5/ 
> pom.xml (original)
> +++ geronimo/server/trunk/assemblies/geronimo-boilerplate-jee5/ 
> pom.xml Wed Jan 31 13:22:32 2007
> @@ -133,26 +133,30 @@
>                          </configuration>
>                      </execution>
>
> -                    <execution>
> -                        <id>install-lib-endorsed</id>
> -                        <phase>compile</phase>
> -                        <goals>
> -                            <goal>copy</goal>
> -                        </goals>
> -                        <configuration>
> -                            <artifactItems>
> -                                <artifactItem>
> -                                    <groupId>org.apache.yoko</ 
> groupId>
> -                                    <artifactId>yoko-spec-corba</ 
> artifactId>
> -                                </artifactItem>
> -                                <artifactItem>
> -                                    <groupId>org.apache.yoko</ 
> groupId>
> -                                    <artifactId>yoko-rmi-spec</ 
> artifactId>
> -                                </artifactItem>
> -                            </artifactItems>
> -                            <outputDirectory>$ 
> {project.build.directory}/classes/lib/endorsed</outputDirectory>
> -                        </configuration>
> -                    </execution>
> +<!--                     Don't include yoko jars in lib/endorsed.  
> This is a temporary measure to avoid -->
> +<!--                     PortableRemoteObject constructor errors.  
> Yoko jars will need to be reinstated -->
> +<!--                     when we have corba support -->
> +
> +<!--                     <execution> -->
> +<!--                         <id>install-lib-endorsed</id> -->
> +<!--                         <phase>compile</phase> -->
> +<!--                         <goals> -->
> +<!--                             <goal>copy</goal> -->
> +<!--                         </goals> -->
> +<!--                         <configuration> -->
> +<!--                             <artifactItems> -->
> +<!--                                 <artifactItem> -->
> +<!--                                     <groupId>org.apache.yoko</ 
> groupId> -->
> +<!--                                     <artifactId>yoko-spec- 
> corba</artifactId> -->
> +<!--                                 </artifactItem> -->
> +<!--                                 <artifactItem> -->
> +<!--                                     <groupId>org.apache.yoko</ 
> groupId> -->
> +<!--                                     <artifactId>yoko-rmi- 
> spec</artifactId> -->
> +<!--                                 </artifactItem> -->
> +<!--                             </artifactItems> -->
> +<!--                             <outputDirectory>$ 
> {project.build.directory}/classes/lib/endorsed</outputDirectory> -->
> +<!--                         </configuration> -->
> +<!--                     </execution> -->
>
>                      <execution>
>                          <id>install-lib</id>
>
>


Re: svn commit: r502004 - /geronimo/server/trunk/assemblies/geronimo-boilerplate-jee5/pom.xml

Posted by Jason Dillon <ja...@planet57.com>.
Um... would it be possible to *not* use this comment style in the  
future?

I know that IDEA makes this nice any easy to comment and uncomment  
like this, but if you don't use IDEA then its a PITA to remove these  
comments. I think its also kinda ugly looking, but thats just me... :-(

--jason


On Jan 31, 2007, at 1:22 PM, kevan@apache.org wrote:

> Author: kevan
> Date: Wed Jan 31 13:22:32 2007
> New Revision: 502004
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=502004
> Log:
> GERONIMO-2788 Don't include yoko jars until we have more corba support
>
> Modified:
>     geronimo/server/trunk/assemblies/geronimo-boilerplate-jee5/pom.xml
>
> Modified: geronimo/server/trunk/assemblies/geronimo-boilerplate- 
> jee5/pom.xml
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/assemblies/ 
> geronimo-boilerplate-jee5/pom.xml? 
> view=diff&rev=502004&r1=502003&r2=502004
> ====================================================================== 
> ========
> --- geronimo/server/trunk/assemblies/geronimo-boilerplate-jee5/ 
> pom.xml (original)
> +++ geronimo/server/trunk/assemblies/geronimo-boilerplate-jee5/ 
> pom.xml Wed Jan 31 13:22:32 2007
> @@ -133,26 +133,30 @@
>                          </configuration>
>                      </execution>
>
> -                    <execution>
> -                        <id>install-lib-endorsed</id>
> -                        <phase>compile</phase>
> -                        <goals>
> -                            <goal>copy</goal>
> -                        </goals>
> -                        <configuration>
> -                            <artifactItems>
> -                                <artifactItem>
> -                                    <groupId>org.apache.yoko</ 
> groupId>
> -                                    <artifactId>yoko-spec-corba</ 
> artifactId>
> -                                </artifactItem>
> -                                <artifactItem>
> -                                    <groupId>org.apache.yoko</ 
> groupId>
> -                                    <artifactId>yoko-rmi-spec</ 
> artifactId>
> -                                </artifactItem>
> -                            </artifactItems>
> -                            <outputDirectory>$ 
> {project.build.directory}/classes/lib/endorsed</outputDirectory>
> -                        </configuration>
> -                    </execution>
> +<!--                     Don't include yoko jars in lib/endorsed.  
> This is a temporary measure to avoid -->
> +<!--                     PortableRemoteObject constructor errors.  
> Yoko jars will need to be reinstated -->
> +<!--                     when we have corba support -->
> +
> +<!--                     <execution> -->
> +<!--                         <id>install-lib-endorsed</id> -->
> +<!--                         <phase>compile</phase> -->
> +<!--                         <goals> -->
> +<!--                             <goal>copy</goal> -->
> +<!--                         </goals> -->
> +<!--                         <configuration> -->
> +<!--                             <artifactItems> -->
> +<!--                                 <artifactItem> -->
> +<!--                                     <groupId>org.apache.yoko</ 
> groupId> -->
> +<!--                                     <artifactId>yoko-spec- 
> corba</artifactId> -->
> +<!--                                 </artifactItem> -->
> +<!--                                 <artifactItem> -->
> +<!--                                     <groupId>org.apache.yoko</ 
> groupId> -->
> +<!--                                     <artifactId>yoko-rmi- 
> spec</artifactId> -->
> +<!--                                 </artifactItem> -->
> +<!--                             </artifactItems> -->
> +<!--                             <outputDirectory>$ 
> {project.build.directory}/classes/lib/endorsed</outputDirectory> -->
> +<!--                         </configuration> -->
> +<!--                     </execution> -->
>
>                      <execution>
>                          <id>install-lib</id>
>
>