You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by el...@apache.org on 2009/03/08 18:22:14 UTC

svn commit: r751473 - in /mina/trunk: core/src/test/java/org/apache/mina/core/ core/src/test/java/org/apache/mina/filter/firewall/ core/src/test/java/org/apache/mina/filter/keepalive/ core/src/test/java/org/apache/mina/proxy/ core/src/test/java/org/apa...

Author: elecharny
Date: Sun Mar  8 17:22:14 2009
New Revision: 751473

URL: http://svn.apache.org/viewvc?rev=751473&view=rev
Log:
Commented a bunch of System.out and PrintStackTrace calls in the tests to lower the verbosity when running the tests.

Modified:
    mina/trunk/core/src/test/java/org/apache/mina/core/IoFilterChainTest.java
    mina/trunk/core/src/test/java/org/apache/mina/core/IoServiceListenerSupportTest.java
    mina/trunk/core/src/test/java/org/apache/mina/filter/firewall/ConnectionThrottleFilterTest.java
    mina/trunk/core/src/test/java/org/apache/mina/filter/keepalive/KeepAliveFilterTest.java
    mina/trunk/core/src/test/java/org/apache/mina/proxy/HttpAuthTest.java
    mina/trunk/core/src/test/java/org/apache/mina/proxy/MD4Test.java
    mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractBindTest.java
    mina/trunk/core/src/test/java/org/apache/mina/transport/vmpipe/VmPipeSessionCrossCommunicationTest.java
    mina/trunk/example/src/test/java/org/apache/mina/example/echoserver/ConnectorTest.java
    mina/trunk/example/src/test/java/org/apache/mina/example/echoserver/ssl/SslFilterTest.java
    mina/trunk/example/src/test/java/org/apache/mina/example/proxy/ClientSessionHandler.java
    mina/trunk/example/src/test/java/org/apache/mina/example/proxy/Socks5GSSAPITestServer.java
    mina/trunk/example/src/test/java/org/apache/mina/example/proxy/telnet/TelnetSessionHandler.java

Modified: mina/trunk/core/src/test/java/org/apache/mina/core/IoFilterChainTest.java
URL: http://svn.apache.org/viewvc/mina/trunk/core/src/test/java/org/apache/mina/core/IoFilterChainTest.java?rev=751473&r1=751472&r2=751473&view=diff
==============================================================================
--- mina/trunk/core/src/test/java/org/apache/mina/core/IoFilterChainTest.java (original)
+++ mina/trunk/core/src/test/java/org/apache/mina/core/IoFilterChainTest.java Sun Mar  8 17:22:14 2009
@@ -75,7 +75,7 @@
         public void exceptionCaught(IoSession session, Throwable cause) {
             result += "HEC";
             if (cause.getClass() != Exception.class) {
-                cause.printStackTrace(System.out);
+                //cause.printStackTrace(System.out);
             }
         }
 
@@ -230,8 +230,8 @@
         result = formatResult(result);
         expectedResult = formatResult(expectedResult);
 
-        System.out.println("Expected: " + expectedResult);
-        System.out.println("Actual:   " + result);
+        //System.out.println("Expected: " + expectedResult);
+        //System.out.println("Actual:   " + result);
         assertEquals(expectedResult, result);
     }
 

Modified: mina/trunk/core/src/test/java/org/apache/mina/core/IoServiceListenerSupportTest.java
URL: http://svn.apache.org/viewvc/mina/trunk/core/src/test/java/org/apache/mina/core/IoServiceListenerSupportTest.java?rev=751473&r1=751472&r2=751473&view=diff
==============================================================================
--- mina/trunk/core/src/test/java/org/apache/mina/core/IoServiceListenerSupportTest.java (original)
+++ mina/trunk/core/src/test/java/org/apache/mina/core/IoServiceListenerSupportTest.java Sun Mar  8 17:22:14 2009
@@ -184,7 +184,7 @@
                 try {
                     Thread.sleep(500);
                 } catch (InterruptedException e) {
-                    e.printStackTrace();
+                    //e.printStackTrace();
                 }
                 // This synchronization block is a workaround for
                 // the visibility problem of simultaneous EasyMock

Modified: mina/trunk/core/src/test/java/org/apache/mina/filter/firewall/ConnectionThrottleFilterTest.java
URL: http://svn.apache.org/viewvc/mina/trunk/core/src/test/java/org/apache/mina/filter/firewall/ConnectionThrottleFilterTest.java?rev=751473&r1=751472&r2=751473&view=diff
==============================================================================
--- mina/trunk/core/src/test/java/org/apache/mina/filter/firewall/ConnectionThrottleFilterTest.java (original)
+++ mina/trunk/core/src/test/java/org/apache/mina/filter/firewall/ConnectionThrottleFilterTest.java Sun Mar  8 17:22:14 2009
@@ -65,7 +65,7 @@
         }
         catch ( InterruptedException e )
         {
-            e.printStackTrace();
+            //e.printStackTrace();
         }
 
         boolean result = filter.isConnectionOk( sessionOne );

Modified: mina/trunk/core/src/test/java/org/apache/mina/filter/keepalive/KeepAliveFilterTest.java
URL: http://svn.apache.org/viewvc/mina/trunk/core/src/test/java/org/apache/mina/filter/keepalive/KeepAliveFilterTest.java?rev=751473&r1=751472&r2=751473&view=diff
==============================================================================
--- mina/trunk/core/src/test/java/org/apache/mina/filter/keepalive/KeepAliveFilterTest.java (original)
+++ mina/trunk/core/src/test/java/org/apache/mina/filter/keepalive/KeepAliveFilterTest.java Sun Mar  8 17:22:14 2009
@@ -105,14 +105,14 @@
             @Override
             public void exceptionCaught(IoSession session, Throwable cause)
                     throws Exception {
-                cause.printStackTrace();
+                //cause.printStackTrace();
                 gotException.set(true);
             }
 
             @Override
             public void sessionIdle(IoSession session, IdleStatus status)
                     throws Exception {
-                System.out.println("client idle:" + status);
+                //System.out.println("client idle:" + status);
             }
         });
 

Modified: mina/trunk/core/src/test/java/org/apache/mina/proxy/HttpAuthTest.java
URL: http://svn.apache.org/viewvc/mina/trunk/core/src/test/java/org/apache/mina/proxy/HttpAuthTest.java?rev=751473&r1=751472&r2=751473&view=diff
==============================================================================
--- mina/trunk/core/src/test/java/org/apache/mina/proxy/HttpAuthTest.java (original)
+++ mina/trunk/core/src/test/java/org/apache/mina/proxy/HttpAuthTest.java Sun Mar  8 17:22:14 2009
@@ -81,7 +81,7 @@
             assertEquals("6629fae49393a05397450978507c4ef1", response);
             writeResponse(map, response);
         } catch (Exception e) {
-            e.printStackTrace();
+            //e.printStackTrace();
         }
     }
 
@@ -113,6 +113,6 @@
             }
         }
 
-        System.out.println("Proxy-Authorization: " + sb.toString());
+        //System.out.println("Proxy-Authorization: " + sb.toString());
     }
 }
\ No newline at end of file

Modified: mina/trunk/core/src/test/java/org/apache/mina/proxy/MD4Test.java
URL: http://svn.apache.org/viewvc/mina/trunk/core/src/test/java/org/apache/mina/proxy/MD4Test.java?rev=751473&r1=751472&r2=751473&view=diff
==============================================================================
--- mina/trunk/core/src/test/java/org/apache/mina/proxy/MD4Test.java (original)
+++ mina/trunk/core/src/test/java/org/apache/mina/proxy/MD4Test.java Sun Mar  8 17:22:14 2009
@@ -48,7 +48,7 @@
         if (Security.getProvider(MD4Provider.PROVIDER_NAME) == null) {
             System.out.print("Adding MINA provider...");
             Security.addProvider(new MD4Provider());
-            System.out.println(" [Ok]");
+            //System.out.println(" [Ok]");
         }
     }
 
@@ -103,6 +103,6 @@
         String result = asHex(md4.digest(testVector.getBytes()));
         System.out.print(result);
         assertEquals(expected, result);
-        System.out.println(" ... Ok");
+        //System.out.println(" ... Ok");
     }
 }

Modified: mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractBindTest.java
URL: http://svn.apache.org/viewvc/mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractBindTest.java?rev=751473&r1=751472&r2=751473&view=diff
==============================================================================
--- mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractBindTest.java (original)
+++ mina/trunk/core/src/test/java/org/apache/mina/transport/AbstractBindTest.java Sun Mar  8 17:22:14 2009
@@ -241,9 +241,9 @@
         for (int i = 0; i < 1048576; i++) {
             acceptor.bind();
             acceptor.unbind();
-            if (i % 100 == 0) {
-                System.out.println(i + " (" + new Date() + ")");
-            }
+            //if (i % 100 == 0) {
+                //System.out.println(i + " (" + new Date() + ")");
+            //}
         }
         bind(false);
     }
@@ -270,7 +270,7 @@
 
         @Override
         public void exceptionCaught(IoSession session, Throwable cause) {
-            cause.printStackTrace();
+            //cause.printStackTrace();
             session.close(true);
         }
 

Modified: mina/trunk/core/src/test/java/org/apache/mina/transport/vmpipe/VmPipeSessionCrossCommunicationTest.java
URL: http://svn.apache.org/viewvc/mina/trunk/core/src/test/java/org/apache/mina/transport/vmpipe/VmPipeSessionCrossCommunicationTest.java?rev=751473&r1=751472&r2=751473&view=diff
==============================================================================
--- mina/trunk/core/src/test/java/org/apache/mina/transport/vmpipe/VmPipeSessionCrossCommunicationTest.java (original)
+++ mina/trunk/core/src/test/java/org/apache/mina/transport/vmpipe/VmPipeSessionCrossCommunicationTest.java Sun Mar  8 17:22:14 2009
@@ -51,7 +51,7 @@
         acceptor.setHandler(new IoHandlerAdapter() {
             @Override
             public void messageReceived(IoSession session, Object message) throws Exception {
-                System.out.println(Thread.currentThread().getName() + ": " + message);
+                //System.out.println(Thread.currentThread().getName() + ": " + message);
 
                 if ("start".equals(message)) {
                     session.write("open new");
@@ -69,10 +69,10 @@
         connector.setHandler(new IoHandlerAdapter() {
             @Override
             public void messageReceived(IoSession session, Object message) throws Exception {
-                System.out.println(Thread.currentThread().getName() + ": " + message);
+                //System.out.println(Thread.currentThread().getName() + ": " + message);
 
                 if ("open new".equals(message)) {
-                    System.out.println("opening c2 from " + Thread.currentThread().getName());
+                    //System.out.println("opening c2 from " + Thread.currentThread().getName());
 
                     IoConnector c2 = new VmPipeConnector();
                     c2.setHandler(new IoHandlerAdapter() {
@@ -83,7 +83,7 @@
 
                         @Override
                         public void messageReceived(IoSession session, Object message) throws Exception {
-                            System.out.println(Thread.currentThread().getName() + ": " + message);
+                            //System.out.println(Thread.currentThread().getName() + ": " + message);
 
                             if ("tell me something on c1 now".equals(message)) {
                                 latch.countDown();

Modified: mina/trunk/example/src/test/java/org/apache/mina/example/echoserver/ConnectorTest.java
URL: http://svn.apache.org/viewvc/mina/trunk/example/src/test/java/org/apache/mina/example/echoserver/ConnectorTest.java?rev=751473&r1=751472&r2=751473&view=diff
==============================================================================
--- mina/trunk/example/src/test/java/org/apache/mina/example/echoserver/ConnectorTest.java (original)
+++ mina/trunk/example/src/test/java/org/apache/mina/example/echoserver/ConnectorTest.java Sun Mar  8 17:22:14 2009
@@ -92,10 +92,10 @@
     private void testConnector(IoConnector connector) throws Exception {
         connector.setHandler(handler);
 
-        System.out.println("* Without localAddress");
+        //System.out.println("* Without localAddress");
         testConnector(connector, false);
 
-        System.out.println("* With localAddress");
+        //System.out.println("* With localAddress");
         testConnector(connector, true);
     }
 

Modified: mina/trunk/example/src/test/java/org/apache/mina/example/echoserver/ssl/SslFilterTest.java
URL: http://svn.apache.org/viewvc/mina/trunk/example/src/test/java/org/apache/mina/example/echoserver/ssl/SslFilterTest.java?rev=751473&r1=751472&r2=751473&view=diff
==============================================================================
--- mina/trunk/example/src/test/java/org/apache/mina/example/echoserver/ssl/SslFilterTest.java (original)
+++ mina/trunk/example/src/test/java/org/apache/mina/example/echoserver/ssl/SslFilterTest.java Sun Mar  8 17:22:14 2009
@@ -91,7 +91,7 @@
         acceptor.setHandler(handler);
         acceptor.bind(new InetSocketAddress(0));
         port = acceptor.getLocalAddress().getPort();
-        System.out.println("MINA server started.");
+        //System.out.println("MINA server started.");
 
         Socket socket = getClientSocket(useSSL);
         int bytesSent = 0;
@@ -123,7 +123,7 @@
             Thread.sleep(100);
         }
 
-        System.out.println("handler: " + handler.sentMessages);
+        //System.out.println("handler: " + handler.sentMessages);
         assertEquals("handler should have sent 2 messages:", 2,
                 handler.sentMessages.size());
         assertTrue(handler.sentMessages.contains("test-1"));
@@ -152,7 +152,7 @@
         @Override
         public void exceptionCaught(IoSession session, Throwable cause)
                 throws Exception {
-            cause.printStackTrace();
+            //cause.printStackTrace();
         }
 
         @Override
@@ -165,7 +165,7 @@
         public void messageSent(IoSession session, Object message)
                 throws Exception {
             sentMessages.add(message.toString());
-            System.out.println(message);
+            //System.out.println(message);
             if (sentMessages.size() >= 2) {
                 session.close(true);
             }

Modified: mina/trunk/example/src/test/java/org/apache/mina/example/proxy/ClientSessionHandler.java
URL: http://svn.apache.org/viewvc/mina/trunk/example/src/test/java/org/apache/mina/example/proxy/ClientSessionHandler.java?rev=751473&r1=751472&r2=751473&view=diff
==============================================================================
--- mina/trunk/example/src/test/java/org/apache/mina/example/proxy/ClientSessionHandler.java (original)
+++ mina/trunk/example/src/test/java/org/apache/mina/example/proxy/ClientSessionHandler.java Sun Mar  8 17:22:14 2009
@@ -126,7 +126,7 @@
             // position and the limit is written to the file
             wChannel.write(buf.buf());
         } catch (IOException e) {
-            e.printStackTrace();
+            //e.printStackTrace();
         }
     }
 
@@ -161,7 +161,7 @@
     @Override
     public void exceptionCaught(IoSession session, Throwable cause) {
         logger.debug("CLIENT - Exception caught");
-        cause.printStackTrace();
+        //cause.printStackTrace();
         session.close(true);
     }
 }
\ No newline at end of file

Modified: mina/trunk/example/src/test/java/org/apache/mina/example/proxy/Socks5GSSAPITestServer.java
URL: http://svn.apache.org/viewvc/mina/trunk/example/src/test/java/org/apache/mina/example/proxy/Socks5GSSAPITestServer.java?rev=751473&r1=751472&r2=751473&view=diff
==============================================================================
--- mina/trunk/example/src/test/java/org/apache/mina/example/proxy/Socks5GSSAPITestServer.java (original)
+++ mina/trunk/example/src/test/java/org/apache/mina/example/proxy/Socks5GSSAPITestServer.java Sun Mar  8 17:22:14 2009
@@ -191,7 +191,7 @@
                 // and finally block will close session 			    
                 Thread.sleep(500);
             } catch (Exception ex) {
-                ex.printStackTrace();
+                //ex.printStackTrace();
             } finally {
                 context.dispose();
                 socket.close();

Modified: mina/trunk/example/src/test/java/org/apache/mina/example/proxy/telnet/TelnetSessionHandler.java
URL: http://svn.apache.org/viewvc/mina/trunk/example/src/test/java/org/apache/mina/example/proxy/telnet/TelnetSessionHandler.java?rev=751473&r1=751472&r2=751473&view=diff
==============================================================================
--- mina/trunk/example/src/test/java/org/apache/mina/example/proxy/telnet/TelnetSessionHandler.java (original)
+++ mina/trunk/example/src/test/java/org/apache/mina/example/proxy/telnet/TelnetSessionHandler.java Sun Mar  8 17:22:14 2009
@@ -87,7 +87,7 @@
      */
     @Override
     public void messageReceived(IoSession session, Object message) {
-        System.out.println((String) message);
+        //System.out.println((String) message);
     }
 
     /**
@@ -104,7 +104,7 @@
     @Override
     public void exceptionCaught(IoSession session, Throwable cause) {
         logger.debug("CLIENT - Exception caught");
-        cause.printStackTrace();
+        //cause.printStackTrace();
         session.close(true);
     }
 }
\ No newline at end of file