[GitHub] [pulsar] BewareMyPower commented on pull request #10902: Correct TopicName#getPartitionIndex implementation.

[GitBox <gi...@apache.org>]

BewareMyPower commented on pull request #10902:
URL: https://github.com/apache/pulsar/pull/10902#issuecomment-860692080


   Could you please also remove the unused `log` variable in `TopicName`? Just apply following diff.
   
   ```java
   diff --git a/pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java b/pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java
   index bf6db5ff147..2cb9f23153b 100644
   --- a/pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java
   +++ b/pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java
   @@ -29,16 +29,12 @@ import java.util.concurrent.ExecutionException;
    import java.util.concurrent.TimeUnit;
    import org.apache.commons.lang3.StringUtils;
    import org.apache.pulsar.common.util.Codec;
   -import org.slf4j.Logger;
   -import org.slf4j.LoggerFactory;
    
    /**
     * Encapsulate the parsing of the completeTopicName name.
     */
    public class TopicName implements ServiceUnitId {
    
   -    private static final Logger log = LoggerFactory.getLogger(TopicName.class);
   -
        public static final String PUBLIC_TENANT = "public";
        public static final String DEFAULT_NAMESPACE = "default";
    
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org