You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2016/02/15 17:26:14 UTC

traceExit() param order

Hi All:

It seems to me the param order in traceExit() is backward.

It should be: traceExit(message, returnValue), not
traceExit(returnValue, message)

Thoughts?

Gary

-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: traceExit() param order

Posted by Gary Gregory <ga...@gmail.com>.
On Mon, Feb 15, 2016 at 8:33 AM, Ralph Goers <ra...@dslextreme.com>
wrote:

> 6 one way, half a dozen the other.
>

Since you are 50/50 I'll follow my gut and implement.

Gary


>
> Ralph
>
> On Feb 15, 2016, at 9:26 AM, Gary Gregory <ga...@gmail.com> wrote:
>
> Hi All:
>
> It seems to me the param order in traceExit() is backward.
>
> It should be: traceExit(message, returnValue), not
> traceExit(returnValue, message)
>
> Thoughts?
>
> Gary
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: traceExit() param order

Posted by Ralph Goers <ra...@dslextreme.com>.
6 one way, half a dozen the other. 

Ralph

> On Feb 15, 2016, at 9:26 AM, Gary Gregory <ga...@gmail.com> wrote:
> 
> Hi All:
> 
> It seems to me the param order in traceExit() is backward.
> 
> It should be: traceExit(message, returnValue), not traceExit(returnValue, message)
> 
> Thoughts?
> 
> Gary
> 
> -- 
> E-Mail: garydgregory@gmail.com <ma...@gmail.com> | ggregory@apache.org  <ma...@apache.org>
> Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com <http://garygregory.wordpress.com/> 
> Home: http://garygregory.com/ <http://garygregory.com/>
> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>