You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/02/05 22:21:21 UTC
[GitHub] [trafficcontrol] rimashah25 opened a new pull request #5502: Updated MTU check constraint in DB to allow 1280 as a legal value
rimashah25 opened a new pull request #5502:
URL: https://github.com/apache/trafficcontrol/pull/5502
…so, updated test cases to include mtu check.
<!--
************ STOP!! ************
If this Pull Request is intended to fix a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
## What does this PR (Pull Request) do?
<!-- Explain the changes you made here. If this fixes an Issue, identify it by
replacing the text in the checkbox item with the Issue number e.g.
- [x] This PR fixes #9001 OR is not related to any Issue
^ This will automatically close Issue number 9001 when the Pull Request is
merged (The '#' is important).
Be sure you check the box properly, see the "The following criteria are ALL
met by this PR" section for details.
-->
- [x] This PR fixes #5288 <!-- You can check for an issue here: https://github.com/apache/trafficcontrol/issues -->
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this
Pull Request. Also, feel free to add the name of a tool or script that is
affected but not on the list.
Additionally, if this Pull Request does NOT affect documentation, please
explain why documentation is not required. -->
- Traffic Ops
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your Pull Request. If
it includes tests (and most should), outline here the steps needed to run the
tests. If not, lay out the manual testing procedure and please explain why
tests are unnecessary for this Pull Request. -->
1. Create a JSON request where interface.mtu is set to 1280
2. curl using POST API /servers
3. See a 200OK with a server response struct
For eg:
```
curl -X POST -k -H "Accept: application/json" --cookie "mojolicious=<mojolicious id>" --data @post_server_ciab.json https://localhost:6443/api/3.0/servers
{"alerts":[{"text":"Server created","level":"success"}],"response":{"cachegroup":"CDN_in_a_Box_Mid-02","cachegroupId":7,"cdnId":2,"cdnName":"CDN-in-a-Box","domainName":"ciab.com","guid":null,"hostName":"bar","httpsPort":443,"id":19,"iloIpAddress":null,"iloIpGateway":null,"iloIpNetmask":null,"iloPassword":null,"iloUsername":null,"lastUpdated":"2021-02-05 20:45:48+00","mgmtIpAddress":null,"mgmtIpGateway":null,"mgmtIpNetmask":null,"offlineReason":null,"physLocation":"CDN_in_a_Box","physLocationId":2,"profile":"ATS_EDGE_TIER_CACHE","profileDesc":"Edge Cache - Apache Traffic Server","profileId":9,"rack":null,"revalPending":false,"status":"OFFLINE","statusId":1,"tcpPort":80,"type":"EDGE","typeId":11,"updPending":false,"xmppId":"e6966f42-b6be-414e-9534-f04a853aa12a","xmppPasswd":null,"routerHostName":null,"routerPortName":null,"interfaces":[{"ipAddresses":[{"address":"1.2.3.4","gateway":"1.0.0.1","serviceAddress":true}],"maxBandwidth":50,"monitor":true,"mtu":1280,"name":"int0"}],"statusL
astUpdated":"2021-02-05T20:45:48.6267179Z"}}
```
## If this is a bug fix, what versions of Traffic Control are affected?
<!-- If this PR fixes a bug, please list here all of the affected versions - to
the best of your knowledge. It's also pretty helpful to include a commit hash
of where 'master' is at the time this PR is opened (if it affects master),
because what 'master' means will change over time. For example, if this PR
fixes a bug that's present in master (at commit hash '1df853c8'), in v4.0.0,
and in the current 4.0.1 Release candidate (e.g. RC1), then this list would
look like:
- master (1df853c8)
- 4.0.0
- 4.0.1 (RC1)
If you don't know what other versions might have this bug, AND don't know how
to find the commit hash of 'master', then feel free to leave this section
blank (or, preferably, delete it entirely).
-->
- master (daa6a55)
## The following criteria are ALL met by this PR
<!-- Check the boxes to signify that the associated statement is true. To
"check a box", replace the space inside of the square brackets with an 'x'.
e.g.
- [ x] <- Wrong
- [x ] <- Wrong
- [] <- Wrong
- [*] <- Wrong
- [x] <- Correct!
-->
- [x] This PR includes tests
- [x] I have explained why documentation is unnecessary
- [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
## Additional Information
<!-- If you would like to include any additional information on the PR for
potential reviewers please put it here.
Some examples of this would be:
- Before and after screenshots/gifs of the Traffic Portal if it is affected
- Links to other dependent Pull Requests
- References to relevant context (e.g. new/updates to dependent libraries,
mailing list records, blueprints)
Feel free to leave this section blank (or, preferably, delete it entirely).
-->
The documentation is correct
```
The MTU of this interface. If it is null, it may be assumed that the information is either not available or not applicable for this interface. This unsigned integer may not be less than 1280.
```
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rimashah25 commented on a change in pull request #5502: Updated MTU check constraint in DB to allow 1280 as a legal value
Posted by GitBox <gi...@apache.org>.
rimashah25 commented on a change in pull request #5502:
URL: https://github.com/apache/trafficcontrol/pull/5502#discussion_r572257229
##########
File path: traffic_ops/testing/api/v4/servers_test.go
##########
@@ -950,6 +954,11 @@ func UpdateTestServers(t *testing.T) {
t.Fatalf("Cannot test server type change update; server '%s' had nil type ID", hostName)
}
+ // Check to verify mtu changed
+ if originalMTU == *respServer.Interfaces[0].MTU {
+ t.Errorf("MTU value didn't update. Expected: #{*updatedMTU}, actual: #{*originalMTU}")
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 merged pull request #5502: Updated MTU check constraint in DB to allow 1280 as a legal value
Posted by GitBox <gi...@apache.org>.
ocket8888 merged pull request #5502:
URL: https://github.com/apache/trafficcontrol/pull/5502
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5502: Updated MTU check constraint in DB to allow 1280 as a legal value
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #5502:
URL: https://github.com/apache/trafficcontrol/pull/5502#discussion_r571300737
##########
File path: traffic_ops/testing/api/v4/servers_test.go
##########
@@ -885,6 +886,7 @@ func UpdateTestServers(t *testing.T) {
originalHostname := *resp.Response[0].HostName
originalXMPIDD := *resp.Response[0].XMPPID
+ originalMTU := *resp.Response[0].Interfaces[0].MTU
Review comment:
This check should go down below the check for `len(infs)` on line 896 to avoid a segfault. For the same reason, should also check that MTU is not `nil` before dereferencing it
##########
File path: traffic_ops/app/db/migrations/2021020500000000_change_mtu_check_interfaces.sql
##########
@@ -0,0 +1,21 @@
+/*
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+*/
+
+-- +goose Up
+-- SQL in section 'Up' is executed when this migration is applied
+ALTER TABLE interface DROP CONSTRAINT interface_mtu_check;
+ALTER TABLE interface ADD CONSTRAINT interface_mtu_check CHECK (((mtu IS NULL) OR (mtu >= 1280)));
+
+-- +goose Down
+-- SQL section 'Down' is executed when this migration is rolled back
+ALTER TABLE interface DROP CONSTRAINT interface_mtu_check;
+ALTER TABLE interface ADD CONSTRAINT interface_mtu_check CHECK (((mtu IS NULL) OR (mtu > 1280)));
Review comment:
Missing newline at EOF
##########
File path: traffic_ops/testing/api/v4/servers_test.go
##########
@@ -950,6 +954,11 @@ func UpdateTestServers(t *testing.T) {
t.Fatalf("Cannot test server type change update; server '%s' had nil type ID", hostName)
}
+ // Check to verify mtu changed
+ if originalMTU == *respServer.Interfaces[0].MTU {
Review comment:
Need to check that `respServer.Interfaces` has a length of at least one, and that the 0<sup>th</sup> element has a non-`nil` MTU before dereferencing like this, to avoid a segfault.
##########
File path: traffic_ops/testing/api/v4/servers_test.go
##########
@@ -950,6 +954,11 @@ func UpdateTestServers(t *testing.T) {
t.Fatalf("Cannot test server type change update; server '%s' had nil type ID", hostName)
}
+ // Check to verify mtu changed
+ if originalMTU == *respServer.Interfaces[0].MTU {
+ t.Errorf("MTU value didn't update. Expected: #{*updatedMTU}, actual: #{*originalMTU}")
Review comment:
I don't think this is going to print out the values, I think this will just literally print out
```
MTU value didn't update. Expected: #{*updatedMTU}, actual: #{*originalMTU}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rimashah25 commented on a change in pull request #5502: Updated MTU check constraint in DB to allow 1280 as a legal value
Posted by GitBox <gi...@apache.org>.
rimashah25 commented on a change in pull request #5502:
URL: https://github.com/apache/trafficcontrol/pull/5502#discussion_r572256952
##########
File path: traffic_ops/testing/api/v4/servers_test.go
##########
@@ -885,6 +886,7 @@ func UpdateTestServers(t *testing.T) {
originalHostname := *resp.Response[0].HostName
originalXMPIDD := *resp.Response[0].XMPPID
+ originalMTU := *resp.Response[0].Interfaces[0].MTU
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org