You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/20 05:18:59 UTC

[GitHub] [pulsar] eolivelli commented on a change in pull request #12095: [Tiered Storage] Fix read tiered storage ledger data again

eolivelli commented on a change in pull request #12095:
URL: https://github.com/apache/pulsar/pull/12095#discussion_r711882064



##########
File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreBackedReadHandleImpl.java
##########
@@ -92,6 +92,9 @@ public LedgerMetadata getLedgerMetadata() {
     @Override
     public CompletableFuture<LedgerEntries> readAsync(long firstEntry, long lastEntry) {
         log.debug("Ledger {}: reading {} - {}", getId(), firstEntry, lastEntry);
+        if (!inputStream.haveDataToRead()) {

Review comment:
       Is this block to be moved below inside the lamdba ?
   It looks to me that we are not handling correctly concurrency 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org