You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/21 07:31:10 UTC

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1589: Fix Null Mask Handling in ArrayData And UnionArray

tustvold commented on code in PR #1589:
URL: https://github.com/apache/arrow-rs/pull/1589#discussion_r854871960


##########
arrow/src/array/equal/utils.rs:
##########
@@ -240,98 +233,3 @@ pub(super) fn union_child_logical_null_buffer(
         }
     }
 }
-
-// Calculate a list child's logical bitmap/buffer
-#[inline]
-fn logical_list_bitmap<OffsetSize: OffsetSizeTrait>(

Review Comment:
   We only call equal_ranges on the non null ranges



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org