You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2018/06/27 07:35:03 UTC
Re: Review Request 66820: Added per framework metrics 'subscribed' and
helpers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66820/
-----------------------------------------------------------
(Updated June 27, 2018, 12:35 a.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, Greg Mann, Jie Yu, and Vinod Kone.
Bugs: MESOS-8919
https://issues.apache.org/jira/browse/MESOS-8919
Repository: mesos
Description
-------
Added per framework metrics 'subscribed' and helpers.
Diffs (updated)
-----
src/master/master.hpp 4180341e2c7b16503a4376c501f611bb78ba901c
src/master/master.cpp 4ade16f044f8a4fdafd5afaba4e6a23232f83a5a
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/66820/diff/7/
Changes: https://reviews.apache.org/r/66820/diff/6-7/
Testing
-------
Thanks,
Gilbert Song
Re: Review Request 66820: Added per-framework 'subscribed' metric and
helpers.
Posted by Greg Mann <gr...@mesosphere.io>.
> On July 6, 2018, 6:58 p.m., Gastón Kleiman wrote:
> > src/master/master.hpp
> > Lines 2879 (patched)
> > <https://reviews.apache.org/r/66820/diff/7/?file=2046268#file2046268line2879>
> >
> > Nit: I'd make this method take a const ref for consistency. But given that `State` is an enum, I don't think that making a copy has any performance impact.
Fixed while committing.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66820/#review205818
-----------------------------------------------------------
On July 18, 2018, 1:33 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66820/
> -----------------------------------------------------------
>
> (Updated July 18, 2018, 1:33 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, Greg Mann, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-8919
> https://issues.apache.org/jira/browse/MESOS-8919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per-framework 'subscribed' metric and helpers.
>
>
> Diffs
> -----
>
> src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224
> src/master/master.cpp 487ee349ef0cd78903ff6bcdea3f24688810cdc5
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/66820/diff/8/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 66820: Added per framework metrics 'subscribed' and
helpers.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66820/#review205818
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.hpp
Lines 2879 (patched)
<https://reviews.apache.org/r/66820/#comment288725>
Nit: I'd make this method take a const ref for consistency. But given that `State` is an enum, I don't think that making a copy has any performance impact.
- Gastón Kleiman
On June 27, 2018, 12:35 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66820/
> -----------------------------------------------------------
>
> (Updated June 27, 2018, 12:35 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, Greg Mann, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-8919
> https://issues.apache.org/jira/browse/MESOS-8919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per framework metrics 'subscribed' and helpers.
>
>
> Diffs
> -----
>
> src/master/master.hpp 4180341e2c7b16503a4376c501f611bb78ba901c
> src/master/master.cpp 4ade16f044f8a4fdafd5afaba4e6a23232f83a5a
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/66820/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 66820: Added per-framework 'subscribed' metric and
helpers.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66820/#review206223
-----------------------------------------------------------
Ship it!
Ship It!
- Gastón Kleiman
On July 17, 2018, 6:33 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66820/
> -----------------------------------------------------------
>
> (Updated July 17, 2018, 6:33 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, Greg Mann, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-8919
> https://issues.apache.org/jira/browse/MESOS-8919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added per-framework 'subscribed' metric and helpers.
>
>
> Diffs
> -----
>
> src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224
> src/master/master.cpp 487ee349ef0cd78903ff6bcdea3f24688810cdc5
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/66820/diff/8/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 66820: Added per-framework 'subscribed' metric and
helpers.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66820/
-----------------------------------------------------------
(Updated July 18, 2018, 1:33 a.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, Greg Mann, Jie Yu, and Vinod Kone.
Summary (updated)
-----------------
Added per-framework 'subscribed' metric and helpers.
Bugs: MESOS-8919
https://issues.apache.org/jira/browse/MESOS-8919
Repository: mesos
Description (updated)
-------
Added per-framework 'subscribed' metric and helpers.
Diffs (updated)
-----
src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224
src/master/master.cpp 487ee349ef0cd78903ff6bcdea3f24688810cdc5
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/66820/diff/8/
Changes: https://reviews.apache.org/r/66820/diff/7-8/
Testing
-------
Thanks,
Gilbert Song