Re: [PR] ProcfsMetricsGetterSuite [spark]

["yaooqinn (via GitHub)" <gi...@apache.org>]

yaooqinn commented on code in PR #50545:
URL: https://github.com/apache/spark/pull/50545#discussion_r2036413446


##########
core/src/test/scala/org/apache/spark/executor/ProcfsMetricsGetterSuite.scala:
##########
@@ -86,7 +86,7 @@ class ProcfsMetricsGetterSuite extends SparkFunSuite {
       val child = process.toHandle.pid()
       eventually(timeout(10.seconds), interval(100.milliseconds)) {
         val pids = p.computeProcessTree()
-        assert(pids.size === 3)
+        assert(pids.size === 4)
         assert(pids.contains(currentPid))
         assert(pids.contains(child))

Review Comment:
   We can remove this assertion if it's flaky because the following 2 lines satisfy the test requirement 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org