You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@carbondata.apache.org by Zhangshunyu <gi...@git.apache.org> on 2016/10/11 03:38:11 UTC

[GitHub] incubator-carbondata pull request #219: [CARBONDATA-37]Support different tim...

Github user Zhangshunyu commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/219#discussion_r82720156
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/CarbonCSVBasedSeqGenStep.java ---
    @@ -1171,6 +1171,14 @@ else if(isComplexTypeColumn[j]) {
                   DirectDictionaryGenerator directDictionaryGenerator1 =
                       DirectDictionaryKeyGeneratorFactory
                           .getDirectDictionaryGenerator(details.getColumnType());
    +              String[] timeformats = meta.timeFormat.split(",");
    +              for(String timeformat:timeformats){
    --- End diff --
    
    Style, need space:  'for(' => 'for ('  , the same to '){' => ') {', and some other places.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---