You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/10 19:35:13 UTC

[GitHub] [flink] ferenc-csaky commented on a diff in pull request #20987: [FLINK-29432][Connector/Hive] Remove use of GenericNVL and use Colaese

ferenc-csaky commented on code in PR #20987:
URL: https://github.com/apache/flink/pull/20987#discussion_r991586643


##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserTypeCheckProcFactory.java:
##########
@@ -1216,7 +1216,7 @@ protected ExprNodeDesc getXpathOrFuncExprNodeDesc(
                     // Rewrite CASE into NVL
                     desc =
                             ExprNodeGenericFuncDesc.newInstance(
-                                    new GenericUDFNvl(),
+                                    new GenericUDFCoalesce(),

Review Comment:
   I think it would be nice to adapt the comment @ line 1216 as well to keep it consistent. The change itself LGTM.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org