You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/05/17 19:55:16 UTC
[kudu-CR] Clean up tablet-copy error message
Hello Mike Percy, Will Berkeley,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6912
to review the following change.
Change subject: Clean up tablet-copy error message
......................................................................
Clean up tablet-copy error message
The error message when tablet-copy is unauthorized was misleading.
before:
Remote error: Unable to begin tablet copy session: Not authorized:
unauthorized access to method: BeginTabletCopySession: Invalid argument:
Unable to decode tablet copy RPC error message: message: "Not
authorized: unauthorized access to method: BeginTabletCopySession" code:
ERROR_APPLICATION
after:
Remote error: Unable to begin tablet copy session: Not authorized:
unauthorized access to method: BeginTabletCopySession
Change-Id: I39292d55af96dd20b7a26f02972c2013b6e1f95e
---
M src/kudu/tserver/tablet_copy_client.cc
1 file changed, 10 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/6912/1
--
To view, visit http://gerrit.cloudera.org:8080/6912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39292d55af96dd20b7a26f02972c2013b6e1f95e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] Clean up tablet-copy error message
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Clean up tablet-copy error message
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39292d55af96dd20b7a26f02972c2013b6e1f95e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] Clean up tablet-copy error message
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has uploaded a new patch set (#2).
Change subject: Clean up tablet-copy error message
......................................................................
Clean up tablet-copy error message
The error message when tablet-copy is unauthorized was misleading.
before:
Remote error: Unable to begin tablet copy session: Not authorized:
unauthorized access to method: BeginTabletCopySession: Invalid argument:
Unable to decode tablet copy RPC error message: message: "Not
authorized: unauthorized access to method: BeginTabletCopySession" code:
ERROR_APPLICATION
after:
Remote error: Unable to begin tablet copy session: Not authorized:
unauthorized access to method: BeginTabletCopySession
Change-Id: I39292d55af96dd20b7a26f02972c2013b6e1f95e
---
M src/kudu/tserver/tablet_copy_client.cc
M src/kudu/tserver/tablet_copy_client.h
2 files changed, 10 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/6912/2
--
To view, visit http://gerrit.cloudera.org:8080/6912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I39292d55af96dd20b7a26f02972c2013b6e1f95e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] Clean up tablet-copy error message
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Clean up tablet-copy error message
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6912/1/src/kudu/tserver/tablet_copy_client.cc
File src/kudu/tserver/tablet_copy_client.cc:
PS1, Line 330:
> consider removing this method from the header file as well.
Done
--
To view, visit http://gerrit.cloudera.org:8080/6912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39292d55af96dd20b7a26f02972c2013b6e1f95e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] Clean up tablet-copy error message
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Clean up tablet-copy error message
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6912/1/src/kudu/tserver/tablet_copy_client.cc
File src/kudu/tserver/tablet_copy_client.cc:
PS1, Line 330:
consider removing this method from the header file as well.
--
To view, visit http://gerrit.cloudera.org:8080/6912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39292d55af96dd20b7a26f02972c2013b6e1f95e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] Clean up tablet-copy error message
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: Clean up tablet-copy error message
......................................................................
Clean up tablet-copy error message
The error message when tablet-copy is unauthorized was misleading.
before:
Remote error: Unable to begin tablet copy session: Not authorized:
unauthorized access to method: BeginTabletCopySession: Invalid argument:
Unable to decode tablet copy RPC error message: message: "Not
authorized: unauthorized access to method: BeginTabletCopySession" code:
ERROR_APPLICATION
after:
Remote error: Unable to begin tablet copy session: Not authorized:
unauthorized access to method: BeginTabletCopySession
Change-Id: I39292d55af96dd20b7a26f02972c2013b6e1f95e
Reviewed-on: http://gerrit.cloudera.org:8080/6912
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/tserver/tablet_copy_client.cc
M src/kudu/tserver/tablet_copy_client.h
2 files changed, 10 insertions(+), 20 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I39292d55af96dd20b7a26f02972c2013b6e1f95e
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>