You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/01 14:01:59 UTC
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31377: [SPARK-34239][SQL] Unify output of SHOW COLUMNS pass output attributes properly
AngersZhuuuu commented on a change in pull request #31377:
URL: https://github.com/apache/spark/pull/31377#discussion_r567846686
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -935,10 +935,8 @@ case class ShowTablePropertiesCommand(table: TableIdentifier, propertyKey: Optio
*/
case class ShowColumnsCommand(
databaseName: Option[String],
- tableName: TableIdentifier) extends RunnableCommand {
- override val output: Seq[Attribute] = {
- AttributeReference("col_name", StringType, nullable = false)() :: Nil
- }
+ tableName: TableIdentifier,
+ override val output: Seq[Attribute]) extends RunnableCommand {
Review comment:
> do we need `override val`?
Same change as last PR https://github.com/apache/spark/pull/31341/files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org