You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/09 08:16:51 UTC

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #2264: sched: task: Fix nxtask_exit() for SMP

masayuki2009 opened a new pull request #2264:
URL: https://github.com/apache/incubator-nuttx/pull/2264


   ## Summary
   
   - I noticed that nxsched_merge_pending() is called outside a critical section
   - The issue happens if a new rtcb does not hold a critical section
   - Actually, global IRQ control is done in nxsched_resume_scheduler() in nxtask_exit()
   - However, nxsched_merge_pending() was called after calling nxsched_resume_scheduler()
   - This commit fixes the issue by moving nxsched_merge_pending() before the function
   - NOTE: the sequence was changed for SMP but works for non-SMP as well
   
   ## Impact
   
   - This commit affects both SMP and non-SMP
   
   ## Testing
   
   - Tested with ostest with the following configurations
   - spresense:wifi_smp (NCPUS=2 and 4)
   - spresense:wifi (non SMP)
   - sabre-6quad:smp (QEMU)
   - esp32-core:smp (QEMU)
   - maix-bit:smp (QEMU)
   - sim:smp
   - lc823450-xgevk:rndis
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] jerpelea merged pull request #2264: sched: task: Fix nxtask_exit() for SMP

Posted by GitBox <gi...@apache.org>.
jerpelea merged pull request #2264:
URL: https://github.com/apache/incubator-nuttx/pull/2264


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2264: sched: task: Fix nxtask_exit() for SMP

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #2264:
URL: https://github.com/apache/incubator-nuttx/pull/2264#issuecomment-724376051


   @btashton 
   Could you backport this PR to 10.0?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org