[GitHub] [rocketmq] Git-Yang commented on a change in pull request #3483: fix(consumer): DefaultMQPushConsumerImpl#adjustThreadPool() has no effect.

[GitBox <gi...@apache.org>]

Git-Yang commented on a change in pull request #3483:
URL: https://github.com/apache/rocketmq/pull/3483#discussion_r749852660



##########
File path: client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java
##########
@@ -110,12 +110,14 @@ public void updateCorePoolSize(int corePoolSize) {
 
     @Override
     public void incCorePoolSize() {
-
+        int corePoolSize = consumeExecutor.getCorePoolSize();
+        updateCorePoolSize(++corePoolSize);
     }
 
     @Override
     public void decCorePoolSize() {
-
+        int corePoolSize = consumeExecutor.getCorePoolSize();
+        updateCorePoolSize(--corePoolSize);

Review comment:
       Is it necessary to verify that corePoolSize is not less than or equal to 0?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org