You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/04/22 14:06:21 UTC

[GitHub] [incubator-doris] morningman commented on a change in pull request #5692: [Bug] Fix stream load UT failed

morningman commented on a change in pull request #5692:
URL: https://github.com/apache/incubator-doris/pull/5692#discussion_r618434102



##########
File path: be/src/olap/storage_engine.cpp
##########
@@ -227,15 +227,19 @@ Status StorageEngine::_init_store_map() {
         _store_map.emplace(store->path(), store);
     }
 
-    RETURN_NOT_OK_STATUS_WITH_WARN(_init_stream_load_recorder(), "init StreamLoadRecorder failed");
+    std::string stream_load_record_path = "";
+    if (!tmp_stores.empty()) {
+        stream_load_record_path = tmp_stores[0]->path();
+    }
+
+    RETURN_NOT_OK_STATUS_WITH_WARN(_init_stream_load_recorder(stream_load_record_path),
+                                   "init StreamLoadRecorder failed");
 
     return Status::OK();
 }
 
-Status StorageEngine::_init_stream_load_recorder() {
-    std::string stream_load_record_path = config::stream_load_record_path;
+Status StorageEngine::_init_stream_load_recorder(std::string stream_load_record_path) {

Review comment:
       ```suggestion
   Status StorageEngine::_init_stream_load_recorder(const std::string& stream_load_record_path) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org