You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/08/09 10:34:09 UTC
[GitHub] [flink] PatrickRen opened a new pull request, #20517: [FLINK-28890][table] Fix semantic of latestLoadTime in caching lookup function
PatrickRen opened a new pull request, #20517:
URL: https://github.com/apache/flink/pull/20517
## What is the purpose of the change
This PR fixes the semantic of latestLoadTime in caching lookup function
## Brief change log
*(for example:)*
- Fix semantic of latestLoadTime in caching lookup function
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on a diff in pull request #20517: [FLINK-28890][table] Fix semantic of latestLoadTime in caching lookup function
Posted by GitBox <gi...@apache.org>.
leonardBang commented on code in PR #20517:
URL: https://github.com/apache/flink/pull/20517#discussion_r941194581
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/CachingAsyncLookupFunction.java:
##########
@@ -124,10 +125,10 @@ public LookupCache getCache() {
}
// --------------------------------- Helper functions ----------------------------
- private void updateLatestLoadTime() {
+ private synchronized void updateLatestLoadTime(long loadTime) {
Review Comment:
```
@Override
public void close() throws Exception {
delegate.close();
if (cacheIdentifier != null) {
LookupCacheManager.getInstance().unregisterCache(cacheIdentifier);
}
}
```
minor: check null before close
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20517: [FLINK-28890][table] Fix semantic of latestLoadTime in caching lookup function
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20517:
URL: https://github.com/apache/flink/pull/20517#issuecomment-1209239827
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "267aaa6f05c459bf82a7289317d6bab1a6eb80a2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "267aaa6f05c459bf82a7289317d6bab1a6eb80a2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 267aaa6f05c459bf82a7289317d6bab1a6eb80a2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-28890][table] Fix semantic of latestLoadTime in caching lookup function [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20517:
URL: https://github.com/apache/flink/pull/20517#issuecomment-2768300628
This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-28890][table] Fix semantic of latestLoadTime in caching lookup function [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20517:
URL: https://github.com/apache/flink/pull/20517#issuecomment-2592598227
This PR is being marked as stale since it has not had any activity in the last 180 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
<p>
If you are having difficulty finding a reviewer, please reach out to the
[community](https://flink.apache.org/what-is-flink/community/).
<p>
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 90 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] PatrickRen commented on a diff in pull request #20517: [FLINK-28890][table] Fix semantic of latestLoadTime in caching lookup function
Posted by GitBox <gi...@apache.org>.
PatrickRen commented on code in PR #20517:
URL: https://github.com/apache/flink/pull/20517#discussion_r941279396
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/CachingAsyncLookupFunction.java:
##########
@@ -124,10 +125,10 @@ public LookupCache getCache() {
}
// --------------------------------- Helper functions ----------------------------
- private void updateLatestLoadTime() {
+ private synchronized void updateLatestLoadTime(long loadTime) {
Review Comment:
Thanks for the review! The null check will be included in the full caching implementation. I'll leave it as is for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-28890][table] Fix semantic of latestLoadTime in caching lookup function [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #20517: [FLINK-28890][table] Fix semantic of latestLoadTime in caching lookup function
URL: https://github.com/apache/flink/pull/20517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org